RE: [PATCH v4.14] usb: gadget: f_fs: Fix setting of device and driver data cross-references

From: Andrew Gabbasov <andrew_gabbasov@mentor.com>
To: 'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>
Cc: Macpaul Lin <macpaul.lin@mediatek.com>,
	Eugeniu Rosca <erosca@de.adit-jv.com>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<stable@vger.kernel.org>, Felipe Balbi <balbi@kernel.org>,
	Eugeniu Rosca <roscaeugeniu@gmail.com>,
	Eddie Hung <eddie.hung@mediatek.com>
Subject: RE: [PATCH v4.14] usb: gadget: f_fs: Fix setting of device and driver data cross-references
Date: Sun, 11 Jul 2021 18:37:20 +0300	[thread overview]
Message-ID: <000001d7766a$a755ada0$f60108e0$@mentor.com> (raw)
In-Reply-To: <YOLiDSs/9+RzMKqE@kroah.com>

Hello Greg,

> -----Original Message-----
> From: 'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>
> Sent: Monday, July 05, 2021 1:42 PM
> To: Gabbasov, Andrew <Andrew_Gabbasov@mentor.com>
> Cc: Macpaul Lin <macpaul.lin@mediatek.com>; Eugeniu Rosca <erosca@de.adit-jv.com>; linux-usb@vger.kernel.org;
> linux-kernel@vger.kernel.org; stable@vger.kernel.org; Felipe Balbi <balbi@kernel.org>; Eugeniu Rosca
> <roscaeugeniu@gmail.com>; Eddie Hung <eddie.hung@mediatek.com>
> Subject: Re: [PATCH v4.14] usb: gadget: f_fs: Fix setting of device and driver data cross-references
> 
> On Mon, Jul 05, 2021 at 01:24:10PM +0300, Andrew Gabbasov wrote:
> > Hello Greg,
> >
> > > -----Original Message-----
> > > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Sent: Monday, July 05, 2021 10:08 AM
> > > To: Gabbasov, Andrew <Andrew_Gabbasov@mentor.com>
> > > Cc: Macpaul Lin <macpaul.lin@mediatek.com>; Eugeniu Rosca <erosca@de.adit-jv.com>; linux-usb@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; stable@vger.kernel.org; Felipe Balbi <balbi@kernel.org>; Eugeniu Rosca
> > > <roscaeugeniu@gmail.com>; Eddie Hung <eddie.hung@mediatek.com>
> > > Subject: Re: [PATCH v4.14] usb: gadget: f_fs: Fix setting of device and driver data cross-references
> > >
> > > On Fri, Jul 02, 2021 at 01:49:57PM -0500, Andrew Gabbasov wrote:
> > > > Fixes: 4b187fceec3c ("usb: gadget: FunctionFS: add devices management code")
> > > > Fixes: 3262ad824307 ("usb: gadget: f_fs: Stop ffs_closed NULL pointer dereference")
> > > > Fixes: cdafb6d8b8da ("usb: gadget: f_fs: Fix use-after-free in ffs_free_inst")
> > > > Reported-by: Bhuvanesh Surachari <bhuvanesh_surachari@mentor.com>
> > > > Tested-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> > > > Reviewed-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> > > > Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
> > > > Link: https://lore.kernel.org/r/20210603171507.22514-1-andrew_gabbasov@mentor.com
> > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > (cherry-picked from commit ecfbd7b9054bddb12cea07fda41bb3a79a7b0149)
> > >
> > > There is no such commit id in Linus's tree :(
> > >
> > > Please resubmit with the correct id.
> >
> > This commit is not yet included to the mainline, it only exists in linux-next:
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-
> next.git/commit/?id=ecfbd7b9054bddb12cea07fda41bb3a79a7b0149
> >
> > Could you please advise if I need to somehow denote the linux-next repo in the "cherry picked from" line,
> > or just remove this line, or so far wait and re-submit the patch after the original commit is merged to Linus'
> tree?
> > BTW, I just noticed that the line contains incorrect "cherry-picked" instead of "cherry picked",
> > so I'll have to re-submit the patch anyway 😉
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read:
>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
> 
> Patches have to be in Linus's tree first before we can take it into a
> stable tree.  Please feel free to resubmit this once it is in a -rc
> release.

Sorry I was one day early before the commit was included to Linus' tree.
Now it is there and I'm re-submitting the patch, back-ported to v4.14.

Thanks!

Best regards,
Andrew