From: "Amir Hermelin" <amir@montilio.com>
To: "'William Lee Irwin III'" <wli@holomorphy.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: RE: PG_reserved bug
Date: Wed, 26 Nov 2003 14:45:06 +0200 [thread overview]
Message-ID: <003e01c3b41b$22140580$1d01a8c0@CARTMAN> (raw)
In-Reply-To: <20031126101744.GJ8039@holomorphy.com>
Ok, fair enough. According to what you say, this behavior won't change in
2.6. So, I'm still left with my second question: since I do access the
pages from several places in my module, and I want to use the refcount field
of the struct page (and not have to wrap the pages in another structure) so
I know when my page is no longer referenced, how can I make sure it's 'safe'
to not use the reserved bit?
Amir.
-----Original Message-----
From: William Lee Irwin III [mailto:wli@holomorphy.com]
Sent: Wednesday, November 26, 2003 12:18 PM
To: Amir Hermelin
Cc: linux-kernel@vger.kernel.org
Subject: Re: PG_reserved bug
On Wed, Nov 26, 2003 at 12:09:58PM +0200, Amir Hermelin wrote:
> Hi,
> I've found a bug in the 2.4.20 kernel (might have appeared before),
> that if the PG_reserved flag is set on a page, its reference count
> will be incremented but won't be decremented. This is due to the
> wrong order of lazy if tests in __free_pages(). I have two questions:
> 1. How do I report it? I found no maintainer for MM in MAINTAINERS
> 2. I'm writing a module that gets pages (via __get_free_pages) and holds
> them throughout its lifetime. Where must I check if this page can be
taken
> from under me, without using the reserved bit? In other words, if I want
to
> make sure the behavior is the same with or without the reserved bit, what
> must I maintain?
Reserved pages are excepted from normal reference counting rules. The
allocators of reserved pages are expected to clear reference counts
themselves before returning them to the system (if they ever do).
-- wli
next prev parent reply other threads:[~2003-11-26 12:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-26 10:09 PG_reserved bug Amir Hermelin
2003-11-26 10:17 ` William Lee Irwin III
2003-11-26 12:45 ` Amir Hermelin [this message]
2003-11-26 12:50 ` William Lee Irwin III
2003-11-26 13:07 ` Amir Hermelin
2003-11-26 13:09 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003e01c3b41b$22140580$1d01a8c0@CARTMAN' \
--to=amir@montilio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).