From: Vitaly Rodionov <vitalyr@opensource.cirrus.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: <patches@opensource.cirrus.com>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/4] ALSA: hda/cirrus: Add jack detect interrupt support from CS42L42 companion codec.
Date: Tue, 9 Mar 2021 13:41:48 +0000 [thread overview]
Message-ID: <00537bf3-926c-eb2f-98ed-3d0242ecd8fd@opensource.cirrus.com> (raw)
In-Reply-To: <3ddc27d5-7d6d-e244-51fa-6ac17ee9779a@linux.intel.com>
On 08/03/2021 3:35 pm, Pierre-Louis Bossart wrote:
>
>
>
>> @@ -38,6 +39,15 @@ struct cs_spec {
>> /* for MBP SPDIF control */
>> int (*spdif_sw_put)(struct snd_kcontrol *kcontrol,
>> struct snd_ctl_elem_value *ucontrol);
>> +
>> + unsigned int cs42l42_hp_jack_in:1;
>> + unsigned int cs42l42_mic_jack_in:1;
>> +
>> + struct mutex cs8409_i2c_mux;
>
> what does this protect? there isn't any comment or explanations in the
> commit message.
>
>
we are protecting sequences of i2c transactions.
for example, when we are writing sequence to activate jack detect, as a
result of interrupt via gpio4
unsolicited response can be called by framework at the same time. we
want to finish first sequence.
next prev parent reply other threads:[~2021-03-09 13:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 11:19 [PATCH v3 0/4] ALSA: hda/cirrus: Add support for CS8409 HDA bridge and CS42L42 companion codec Vitaly Rodionov
2021-03-06 11:19 ` [PATCH v3 1/4] ALSA: hda/cirrus: Increase AUTO_CFG_MAX_INS from 8 to 18 Vitaly Rodionov
2021-03-06 11:19 ` [PATCH v3 2/4] ALSA: hda/cirrus: Add support for CS8409 HDA bridge and CS42L42 companion codec Vitaly Rodionov
2021-03-08 15:33 ` Pierre-Louis Bossart
2021-03-09 13:31 ` Vitaly Rodionov
2021-03-06 11:19 ` [PATCH v3 3/4] ALSA: hda/cirrus: Add jack detect interrupt support from " Vitaly Rodionov
2021-03-08 15:35 ` Pierre-Louis Bossart
2021-03-09 13:41 ` Vitaly Rodionov [this message]
2021-03-06 11:19 ` [PATCH v3 4/4] ALSA: hda/cirrus: Add Headphone and Headset MIC Volume Control Vitaly Rodionov
2021-03-08 15:40 ` Pierre-Louis Bossart
2021-03-09 14:21 ` Gerrit
2021-03-07 8:20 ` [PATCH v3 0/4] ALSA: hda/cirrus: Add support for CS8409 HDA bridge and CS42L42 companion codec Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00537bf3-926c-eb2f-98ed-3d0242ecd8fd@opensource.cirrus.com \
--to=vitalyr@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).