RE: [PATCH v2] arm64: dts: qcom: sc7280: Add WPSS remoteproc node

From: <pillair@codeaurora.org>
To: "'Stephen Boyd'" <swboyd@chromium.org>, <agross@kernel.org>,
	<bjorn.andersson@linaro.org>, <robh+dt@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <sibis@codeaurora.org>,
	<mpubbise@codeaurora.org>
Subject: RE: [PATCH v2] arm64: dts: qcom: sc7280: Add WPSS remoteproc node
Date: Thu, 9 Sep 2021 14:08:53 +0530	[thread overview]
Message-ID: <005c01d7a556$220ae9b0$6620bd10$@codeaurora.org> (raw)
In-Reply-To: <CAE-0n539nm6BrR51bZW-jX8e=o5d19JFnKfT9fb-sVS9FGKn0A@mail.gmail.com>

> -----Original Message-----
> From: Stephen Boyd <swboyd@chromium.org>
> Sent: Wednesday, August 11, 2021 1:22 AM
> To: Rakesh Pillai <pillair@codeaurora.org>; agross@kernel.org;
> bjorn.andersson@linaro.org; robh+dt@kernel.org
> Cc: linux-arm-msm@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; sibis@codeaurora.org; mpubbise@codeaurora.org
> Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: Add WPSS remoteproc
> node
> 
> Quoting Rakesh Pillai (2021-08-10 11:11:29)
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > index 53a21d0..41a7826 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > @@ -74,6 +74,16 @@
> >                         reg = <0 0x8b700000 0 0x10000>;
> >                         no-map;
> >                 };
> > +
> > +               wlan_fw_mem: memory@80c00000 {
> > +                       no-map;
> > +                       reg = <0x0 0x80c00000 0x0 0xc00000>;
> > +               };
> 
> Please try to keep this sorted by reg address. 80c00000 comes before
> 8b700000.
> 

Hi Stephen,
I will fix this and send v3 for this patch.

> > +
> > +               wpss_mem: memory@9ae00000 {
> > +                       no-map;
> > +                       reg = <0x0 0x9ae00000 0x0 0x1900000>;
> > +               };
> >         };
> >
> >         cpus {
> > @@ -1270,6 +1280,53 @@
> >                         };
> >                 };
> >
> > +               remoteproc_wpss: remoteproc@8a00000 {
> > +                       compatible = "qcom,sc7280-wpss-pil";
> > +                       reg = <0 0x08a00000 0 0x10000>;
> > +
> > +                       interrupts-extended = <&intc GIC_SPI 587
> IRQ_TYPE_EDGE_RISING>,
> > +                                             <&wpss_smp2p_in 0 IRQ_TYPE_NONE>,
> > +                                             <&wpss_smp2p_in 1 IRQ_TYPE_NONE>,
> > +                                             <&wpss_smp2p_in 2 IRQ_TYPE_NONE>,
> > +                                             <&wpss_smp2p_in 3 IRQ_TYPE_NONE>,
> > +                                             <&wpss_smp2p_in 7
> > + IRQ_TYPE_NONE>;
> 
> Is this IRQ_TYPE_EDGE_RISING? Please add some type of edge or level flag.

I will change it to IRQ_TYPE_EDGE_RISING and send out the next revision.

> 
> > +                       interrupt-names = "wdog", "fatal", "ready", "handover",
> > +                                         "stop-ack", "shutdown-ack";
> > +
> > +                       clocks = <&gcc GCC_WPSS_AHB_BDG_MST_CLK>,
> > +                                <&gcc GCC_WPSS_AHB_CLK>,
> > +                                <&gcc GCC_WPSS_RSCP_CLK>,
> > +                                <&rpmhcc RPMH_CXO_CLK>;
> > +                       clock-names = "gcc_wpss_ahb_bdg_mst_clk",
> > +                                     "gcc_wpss_ahb_clk",
> > +                                     "gcc_wpss_rscp_clk",
> > +                                     "xo";
> > +
> > +                       memory-region = <&wpss_mem>;
> > +
> > +                       qcom,smem-states = <&wpss_smp2p_out 0>;