From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Andy Lutomirski'" <luto@amacapital.net>
Cc: "'Peter Zijlstra'" <peterz@infradead.org>,
"'Ingo Molnar'" <mingo@redhat.com>,
"'Vince Weaver'" <vince@deater.net>,
"'Paul Mackerras'" <paulus@samba.org>,
"'Kees Cook'" <keescook@chromium.org>,
"'Arnaldo Carvalho de Melo'" <acme@kernel.org>,
"'Andrea Arcangeli'" <aarcange@redhat.com>,
<linux-kernel@vger.kernel.org>,
"'Valdis Kletnieks'" <Valdis.Kletnieks@vt.edu>
Subject: RE: [PATCH v2 7/8] x86, perf: Only allow rdpmc if a perf_event is mapped
Date: Tue, 28 Oct 2014 12:07:43 +0800 [thread overview]
Message-ID: <007e01cff264$bce6afc0$36b40f40$@alibaba-inc.com> (raw)
In-Reply-To: <CALCETrW5iJWd65Ems6F3RZL+CxYrQ75nDyFFmgA52ky--pzwTQ@mail.gmail.com>
> >> Subject: Re: [PATCH v2 7/8] x86, perf: Only allow rdpmc if a perf_event is mapped
> >>
> > CPU D CPU A
> > switch_mm
> > load_mm_cr4
> > x86_pmu_event_unmapped
> >
> > I wonder if the X86_CR4_PCE set on CPU D is
> > cleared by CPU A by broadcasting IPI.
> >
>
> It should be okay. The IPI does:
>
> + if (current->mm)
> + load_mm_cr4(current->mm);
>
> which refers to the current task running on the targetted CPU, not to
> the IPI sender's task. So, if it happens after a context switch, it
> will harmlessly reload the new task's cr4.
>
Right, but prev != next is checked in switch_mm.
Hillf
next prev parent reply other threads:[~2014-10-28 4:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 7:16 [PATCH v2 7/8] x86, perf: Only allow rdpmc if a perf_event is mapped 张静(长谷)
2014-10-27 15:45 ` Andy Lutomirski
2014-10-28 3:35 ` Hillf Danton
2014-10-28 3:57 ` Andy Lutomirski
2014-10-28 4:07 ` Hillf Danton [this message]
2014-10-28 4:27 ` Andy Lutomirski
-- strict thread matches above, loose matches on Subject: below --
2014-10-24 22:58 [PATCH v2 0/8] CR4 handling improvements Andy Lutomirski
2014-10-24 22:58 ` [PATCH v2 7/8] x86, perf: Only allow rdpmc if a perf_event is mapped Andy Lutomirski
2014-10-31 17:54 ` Paolo Bonzini
2014-10-31 18:25 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007e01cff264$bce6afc0$36b40f40$@alibaba-inc.com' \
--to=hillf.zj@alibaba-inc.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=aarcange@redhat.com \
--cc=acme@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).