From: <ansuelsmth@gmail.com>
To: "'Rob Herring'" <robh@kernel.org>
Cc: "'Andy Gross'" <agross@kernel.org>,
"'Bjorn Andersson'" <bjorn.andersson@linaro.org>,
"'Kishon Vijay Abraham I'" <kishon@ti.com>,
"'Mark Rutland'" <mark.rutland@arm.com>,
"'linux-arm-msm'" <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: R: [PATCH 2/2] devicetree: bindings: phy: Document dwc3 qcom phy
Date: Wed, 15 Apr 2020 18:01:10 +0200 [thread overview]
Message-ID: <00e301d6133f$15efc1f0$41cf45d0$@gmail.com> (raw)
In-Reply-To: <CAL_JsqLyEy_++q5+JsUmg=gpgh=xkSP7XiQrDvje7tiUHzB8KQ@mail.gmail.com>
> On Wed, Apr 15, 2020 at 7:26 AM <ansuelsmth@gmail.com> wrote:
> >
> > > On Fri, Apr 03, 2020 at 02:26:05AM +0200, Ansuel Smith wrote:
> > > > Document dwc3 qcom phy hs and ss phy bindings needed to correctly
> > > > inizialize and use usb on ipq806x SoC
> > > >
> > > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > > > ---
> > > > .../bindings/phy/qcom,dwc3-hs-usb-phy.yaml | 65
> > > +++++++++++++++++++
> > > > .../bindings/phy/qcom,dwc3-ss-usb-phy.yaml | 65
> > > +++++++++++++++++++
> > > > 2 files changed, 130 insertions(+)
> > > > create mode 100644
> > > Documentation/devicetree/bindings/phy/qcom,dwc3-hs-usb-phy.yaml
> > > > create mode 100644
> > > Documentation/devicetree/bindings/phy/qcom,dwc3-ss-usb-phy.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,dwc3-hs-
> usb-
> > > phy.yaml b/Documentation/devicetree/bindings/phy/qcom,dwc3-hs-
> usb-
> > > phy.yaml
> > > > new file mode 100644
> > > > index 000000000000..0bb59e3c2ab8
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/phy/qcom,dwc3-hs-usb-
> > > phy.yaml
> > > > @@ -0,0 +1,65 @@
> > > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/phy/qcom,dwc3-hs-usb-
> phy.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Qualcomm DWC3 HS PHY CONTROLLER
> > > > +
> > > > +maintainers:
> > > > + - Ansuel Smith <ansuelsmth@gmail.com>
> > > > +
> > > > +description:
> > > > + DWC3 PHY nodes are defined to describe on-chip Synopsis Physical
> > > layer
> > > > + controllers. Each DWC3 PHY controller should have its own node.
> > > > +
> > > > +properties:
> > > > + compatible:
> > > > + const: qcom,dwc3-hs-usb-phy
> > > > +
> > > > + "#phy-cells":
> > > > + const: 0
> > > > +
> > > > + regmap:
> > > > + maxItems: 1
> > > > + description: phandle to usb3 dts definition
> > > > +
> > > > + clocks:
> > > > + minItems: 1
> > > > + maxItems: 2
> > > > +
> > > > + clock-names:
> > > > + minItems: 1
> > > > + maxItems: 2
> > > > + description: |
> > > > + - "ref" Is required
> > > > + - "xo" Optional external reference clock
> > > > + items:
> > > > + - const: ref
> > > > + - const: xo
> > > > +
> > > > +required:
> > > > + - compatible
> > > > + - "#phy-cells"
> > > > + - regmap
> > > > + - clocks
> > > > + - clock-names
> > > > +
> > > > +examples:
> > > > + - |
> > > > + #include <dt-bindings/clock/qcom,gcc-ipq806x.h>
> > > > +
> > > > + hs_phy_0: hs_phy_0 {
> > > > + compatible = "qcom,dwc3-hs-usb-phy";
> > > > + regmap = <&usb3_0>;
> > >
> > > If the registers for the phy are part of 'qcom,dwc3' then make this node
> > > a child of it.
> > >
> >
> > Making this node a child of qcom,dwc3 cause malfunction of the driver.
>
> Fix the driver then.
>
> Rob
Sorry if i bother you but I checked every other usb driver that also needs
phy node. I use regmap phandle here just for the fact that it's the
same reg of dwc3. Others use directly the same reg and are outside their
dwc3 usb node. I think I will follow this path and respin this.
I really hope you are good with this.
next prev parent reply other threads:[~2020-04-15 16:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 0:26 [PATCH 1/2] phy: qualcomm: add qcom dwc3 phy Ansuel Smith
2020-04-03 0:26 ` [PATCH 2/2] devicetree: bindings: phy: Document dwc3 qcom phy Ansuel Smith
2020-04-14 17:38 ` Rob Herring
2020-04-15 12:25 ` R: " ansuelsmth
2020-04-15 13:54 ` Rob Herring
2020-04-15 16:01 ` ansuelsmth [this message]
2020-04-03 8:40 ` [PATCH 1/2] phy: qualcomm: add qcom dwc3 phy Manu Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00e301d6133f$15efc1f0$41cf45d0$@gmail.com' \
--to=ansuelsmth@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).