From: Dmitry Osipenko <digetx@gmail.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
David Heidelberg <david@ixit.cz>,
Svyatoslav Ryhel <clamor95@gmail.com>,
Anton Bambura <jenneron@protonmail.com>,
Antoni Aloy Torrens <aaloytorrens@gmail.com>,
Nikola Milosavljevic <mnidza@outlook.com>,
Ion Agorria <ion@agorria.com>,
Ihor Didenko <tailormoon@rambler.ru>,
Andreas Westman Dorcsak <hedmoo@yahoo.com>,
Maxim Schwalm <maxim.schwalm@gmail.com>,
Raffaele Tranquillini <raffaele.tranquillini@gmail.com>,
Jasper Korten <jja2000@gmail.com>,
Thomas Graichen <thomas.graichen@gmail.com>,
Stefan Eichenberger <stefan.eichenberger@toradex.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 06/24] ARM: tegra: Add common device-tree base for Tegra30 ASUS Transformers
Date: Wed, 1 Dec 2021 17:08:21 +0300 [thread overview]
Message-ID: <00ed819f-8bd8-7116-4f05-8b702a09dc78@gmail.com> (raw)
In-Reply-To: <YadJSRww8we7tzjP@qmqm.qmqm.pl>
01.12.2021 13:07, Michał Mirosław пишет:
> On Wed, Dec 01, 2021 at 01:38:02AM +0300, Dmitry Osipenko wrote:
>> From: Svyatoslav Ryhel <clamor95@gmail.com>
> [...]
>> + i2c2: i2c@7000c400 {
>> + status = "okay";
>> + clock-frequency = <400000>;
>> + };
> [...]
>
> Nit: You could now use the new controller handles directly - that would
> avoid some indentation and duplication. Though I understand it is a lot
> of tedious reformatting.
I see that there are people who prefer to use labels everywhere.
Historically Tegra device-trees never used handles for nodes. I think
should be better to convert all DTs together to keep them consistent,
which I was asking to do before, but nobody wanted to put effort into
doing that.
There are already quite a lot of DT changes scheduled for 5.17, perhaps
better to defer the extra changes for 5.18. I will add it to my todo
list, but if you're going to type the patches, then please either send
them to me, or to ML, or create PR to grate kernel.
At some point in the past we had this common DTSI using labels for
handles, but I asked to keep the DTs consistent, so we don't have them now.
next prev parent reply other threads:[~2021-12-01 14:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 22:37 [PATCH v4 00/24] NVIDIA Tegra ARM32 device-tree patches for 5.17 (new devices and more) Dmitry Osipenko
2021-11-30 22:37 ` [PATCH v4 01/24] dt-bindings: ARM: tegra: Document ASUS Transformers Dmitry Osipenko
2021-11-30 22:37 ` [PATCH v4 02/24] dt-bindings: ARM: tegra: Document Pegatron Chagall Dmitry Osipenko
2021-11-30 22:37 ` [PATCH v4 03/24] ARM: tegra: Add labels to tegra30.dtsi Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 04/24] ARM: tegra: Add labels to tegra114.dtsi Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 05/24] ARM: tegra: Add device-tree for ASUS Transformer EeePad TF101 Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 06/24] ARM: tegra: Add common device-tree base for Tegra30 ASUS Transformers Dmitry Osipenko
2021-12-01 10:07 ` Michał Mirosław
2021-12-01 14:08 ` Dmitry Osipenko [this message]
2021-11-30 22:38 ` [PATCH v4 07/24] ARM: tegra: Add common device-tree for display panel of ASUS devices Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 08/24] ARM: tegra: Add device-tree for ASUS Transformer Prime TF201 Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 09/24] ARM: tegra: Add device-tree for ASUS Transformer Pad TF300T Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 10/24] ARM: tegra: Add device-tree for ASUS Transformer Pad TF300TG Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 11/24] ARM: tegra: Add device-tree for ASUS Transformer Infinity TF700T Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 12/24] ARM: tegra: Add device-tree for ASUS Transformer Pad TF701T Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 13/24] ARM: tegra: Add device-tree for Pegatron Chagall tablet Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 14/24] ARM: tegra: Add device-tree for 1080p version of Nyan Big Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 15/24] ARM: tegra: Add usb-role-switch property to USB OTG ports Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 16/24] ARM: tegra: Enable HDMI CEC on Nyan Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 17/24] ARM: tegra: Enable CPU DFLL " Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 18/24] ARM: tegra: Add CPU thermal zones to Nyan device-tree Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 19/24] ARM: tegra: Name clock and regulator nodes according to DT-schema Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 20/24] ARM: tegra: nexus7: Drop clock-frequency from NFC node Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 21/24] ARM: tegra: nexus7: Use common LVDS display device-tree Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 22/24] ARM: tegra: Enable video decoder on Tegra114 Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 23/24] ARM: tegra_defconfig: Enable drivers wanted by Acer Chromebooks and ASUS tablets Dmitry Osipenko
2021-11-30 22:38 ` [PATCH v4 24/24] ARM: config: multi v7: Enable display drivers used by Tegra devices Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00ed819f-8bd8-7116-4f05-8b702a09dc78@gmail.com \
--to=digetx@gmail.com \
--cc=aaloytorrens@gmail.com \
--cc=clamor95@gmail.com \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=hedmoo@yahoo.com \
--cc=ion@agorria.com \
--cc=jenneron@protonmail.com \
--cc=jja2000@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maxim.schwalm@gmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mnidza@outlook.com \
--cc=raffaele.tranquillini@gmail.com \
--cc=stefan.eichenberger@toradex.com \
--cc=tailormoon@rambler.ru \
--cc=thierry.reding@gmail.com \
--cc=thomas.graichen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).