From: Chanho Park <chanho61.park@samsung.com>
To: "'Linus Walleij'" <linus.walleij@stericsson.com>,
linux-kernel@vger.kernel.org
Cc: "'Stephen Warren'" <swarren@nvidia.com>,
"'Grant Likely'" <grant.likely@secretlab.ca>,
"'Barry Song'" <21cnbao@gmail.com>,
"'Shawn Guo'" <shawn.guo@freescale.com>,
"'Thomas Abraham'" <thomas.abraham@linaro.org>,
"'Dong Aisheng'" <dong.aisheng@linaro.org>,
"'Rajendra Nayak'" <rajendra.nayak@linaro.org>,
"'Haojian Zhuang'" <haojian.zhuang@marvell.com>,
"'Linus Walleij'" <linus.walleij@linaro.org>
Subject: RE: [PATCH v6] pinctrl: add a pin config interface
Date: Wed, 14 Dec 2011 16:04:22 +0900 [thread overview]
Message-ID: <010201ccba2e$9b4564e0$d1d02ea0$%park@samsung.com> (raw)
In-Reply-To: <1323431857-8828-1-git-send-email-linus.walleij@stericsson.com>
> ChangeLog v5->v6:
> - Change to using a pin name as parameter for the
> [get|set]_config() functions, as suggested by Stephen Warren.
> This is more natural as names will be what a developer has
> access to in written documentation etc.
I don't agree with it.
Someone doesn't like to assign a pin name individually because a
pin number is sufficient to represent each pin.
We also provide a macro to define a anonymous pin descriptor.
/* Convenience macro to define a single named or anonymous pin descriptor */
#define PINCTRL_PIN(a, b) { .number = a, .name = b }
#define PINCTRL_PIN_ANON(a) { .number = a }
If we use only the pin name for [get|set]_config(), we must assign the name
of all pins.
IMHO, we also provide pin numbers to control anonymous pins.
--
Best Regards,
Chanho Park
next prev parent reply other threads:[~2011-12-14 7:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 11:57 [PATCH v6] pinctrl: add a pin config interface Linus Walleij
2011-12-12 6:19 ` Haojian Zhuang
2011-12-13 0:22 ` Linus Walleij
2011-12-13 7:21 ` Haojian Zhuang
2011-12-13 12:23 ` Linus Walleij
2011-12-13 21:49 ` Stephen Warren
2011-12-13 22:56 ` Linus Walleij
2011-12-12 10:56 ` Domenico Andreoli
2011-12-13 12:19 ` Linus Walleij
2011-12-14 7:04 ` Chanho Park [this message]
2011-12-14 9:05 ` Linus Walleij
2011-12-14 15:44 ` Stephen Warren
2011-12-14 19:37 ` Linus Walleij
2012-01-18 7:16 ` Thomas Abraham
2012-01-19 16:58 ` Linus Walleij
2012-01-19 18:14 ` Thomas Abraham
[not found] ` <CAJuYYwTP8a4KYDrJ2o9Wmt4jo_DvLviy75T90JnV7Hw10Y+ZXw@mail.gmail.com>
[not found] ` <CACRpkdYwx3O42aC8F+DMV1GL0ce62ZhChOQYdbd7-syunsgBOg@mail.gmail.com>
2012-01-20 15:59 ` Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='010201ccba2e$9b4564e0$d1d02ea0$%park@samsung.com' \
--to=chanho61.park@samsung.com \
--cc=21cnbao@gmail.com \
--cc=dong.aisheng@linaro.org \
--cc=grant.likely@secretlab.ca \
--cc=haojian.zhuang@marvell.com \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rajendra.nayak@linaro.org \
--cc=shawn.guo@freescale.com \
--cc=swarren@nvidia.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).