From: Dan Murphy <dmurphy@ti.com>
To: Florian Fainelli <f.fainelli@gmail.com>, <andrew@lunn.ch>,
<hkallweit1@gmail.com>, <bunk@kernel.org>
Cc: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <grygorii.strashko@ti.com>
Subject: Re: [PATCH net-master 1/1] net: phy: dp83867: Add speed optimization feature
Date: Fri, 31 Jan 2020 14:10:50 -0600 [thread overview]
Message-ID: <01797864-5a63-c3a0-d1d2-99dfff3a0aa1@ti.com> (raw)
In-Reply-To: <d194f979-ca6e-b33f-b18c-f8f238b66897@gmail.com>
Florian
On 1/31/20 2:02 PM, Florian Fainelli wrote:
> On 1/31/20 11:54 AM, Dan Murphy wrote:
> <snip>
>> So then it would be ok to do a genphy_read_status and then override the
>> speed and duplex mode from the PHYSTS register?
> I would think so yes, especially if that is needed for reporting the
> actual link speed that ended up being negotiated, and not the one that
> the link was initially trained at. That assumes I understand that the
> problem is that you advertise and want Gigabit, but because of a 4-wire
> cable being plugged in, you ended up at 100Mbits/sec.
Exactly.
>> I don't think that the link change notification is needed. The speed
>> should not change once the cable is plugged in and the speed is negotiated.
> The link change notification is just to signal to the user that the
> speed may have been reduced due to downshifting, which would/could
> happen with 4-wires instead of the expected 8-wires. Certainly not
> strictly necessary right now, I agree.
Ack
Dan
next prev parent reply other threads:[~2020-01-31 20:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 15:11 [PATCH net-master 0/1] DP83867 Speed optimization feature Dan Murphy
2020-01-31 15:11 ` [PATCH net-master 1/1] net: phy: dp83867: Add speed " Dan Murphy
2020-01-31 17:10 ` Jakub Kicinski
2020-01-31 17:14 ` Dan Murphy
2020-01-31 18:11 ` Jakub Kicinski
2020-01-31 18:36 ` Dan Murphy
2020-01-31 17:49 ` Florian Fainelli
2020-01-31 18:29 ` Dan Murphy
2020-01-31 18:42 ` Florian Fainelli
2020-01-31 19:14 ` Dan Murphy
2020-01-31 19:29 ` Florian Fainelli
2020-01-31 19:54 ` Dan Murphy
2020-01-31 20:02 ` Florian Fainelli
2020-01-31 20:10 ` Dan Murphy [this message]
2020-01-31 20:56 ` Heiner Kallweit
2020-02-01 1:30 ` Dan Murphy
2020-02-01 4:57 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01797864-5a63-c3a0-d1d2-99dfff3a0aa1@ti.com \
--to=dmurphy@ti.com \
--cc=andrew@lunn.ch \
--cc=bunk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).