From: "xiaoguangrong(Xiao Guangrong)" <xiaoguangrong@tencent.com>
To: Kees Cook <keescook@chromium.org>,
"yulei.kernel@gmail.com" <yulei.kernel@gmail.com>,
Stefani Seibold <stefani@seibold.net>,
"Peter Zijlstra" <peterz@infradead.org>,
Will Deacon <will.deacon@arm.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: "mkelly@xevo.com" <mkelly@xevo.com>,
"Jiri Kosina" <jkosina@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
"yuleixzhang(张誉磊)" <yuleixzhang@tencent.com>
Subject: Re: [PATCH] kfifo: add memory barrier in kfifo to prevent data loss
Date: Thu, 3 Jan 2019 07:43:10 +0000 [thread overview]
Message-ID: <019819C6E743904A88B43F7DDEED99BBA7E74E37@EXMBX-SZMAIL006.tencent.com> (raw)
In-Reply-To: CAGXu5jKkqf-9ksvNTCS5xgB_JtfvCc=Eot2uWYYP8rpoKLw=mg@mail.gmail.com
On 12/12/18 8:50 AM, Kees Cook wrote:
> On Mon, Dec 10, 2018 at 7:41 PM <yulei.kernel@gmail.com> wrote:
>>
>> From: Yulei Zhang <yuleixzhang@tencent.com>
>>
>> Early this year we spot there may be two issues in kernel
>> kfifo.
>>
>> One is reported by Xiao Guangrong to linux kernel.
>> https://lkml.org/lkml/2018/5/11/58
>> In current kfifo implementation there are missing memory
>> barrier in the read side, so that without proper barrier
>> between reading the kfifo->in and fetching the data there
>> is potential ordering issue.
>>
>> Beside that, there is another potential issue in kfifo,
>> please consider the following case:
>> at the beginning
>> ring->size = 4
>> ring->out = 0
>> ring->in = 4
>>
>> Consumer Producer
>> --------------- --------------
>> index = ring->out; /* index == 0 */
>> ring->out++; /* ring->out == 1 */
>> < Re-Order >
>> out = ring->out;
>> if (ring->in - out >= ring->mask)
>> return -EFULL;
>> /* see the ring is not full */
>> index = ring->in & ring->mask;
>> /* index == 0 */
>> ring->data[index] = new_data;
>> ring->in++;
>>
>> data = ring->data[index];
>> /* you will find the old data is overwritten by the new_data */
>>
>> In order to avoid the issue:
>> 1) for the consumer, we should read the ring->data[] out before
>> updating ring->out
>> 2) for the producer, we should read ring->out before updating
>> ring->data[]
>>
>> So in this patch we introduce the following four functions which
>> are wrapped with proper memory barrier and keep in pairs to make
>> sure the in and out index are fetched and updated in order to avoid
>> data loss.
>>
>> kfifo_read_index_in()
>> kfifo_write_index_in()
>> kfifo_read_index_out()
>> kfifo_write_index_out()
>>
>> Signed-off-by: Yulei Zhang <yuleixzhang@tencent.com>
>> Signed-off-by: Guangrong Xiao <xiaoguangrong@tencent.com>
>
> I've added some more people to CC that might want to see this. Thanks
> for sending this!
Hi,
Ping... could anyone have a look? ;)
Thanks!
next prev parent reply other threads:[~2019-01-03 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 3:40 [PATCH] kfifo: add memory barrier in kfifo to prevent data loss yulei.kernel
2018-12-12 0:50 ` Kees Cook
2018-12-14 16:25 ` Will Deacon
2019-01-03 7:43 ` xiaoguangrong(Xiao Guangrong) [this message]
2019-01-10 12:34 ` Will Deacon
2018-12-16 15:45 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=019819C6E743904A88B43F7DDEED99BBA7E74E37@EXMBX-SZMAIL006.tencent.com \
--to=xiaoguangrong@tencent.com \
--cc=jkosina@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkelly@xevo.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=stefani@seibold.net \
--cc=will.deacon@arm.com \
--cc=yulei.kernel@gmail.com \
--cc=yuleixzhang@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).