From: Kevin Corry <corryk@us.ibm.com>
To: Greg KH <greg@kroah.com>
Cc: evms-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [ANNOUNCE] EVMS Release 1.2.0
Date: Tue, 1 Oct 2002 16:19:10 -0500 [thread overview]
Message-ID: <02100116191001.20800@boiler> (raw)
In-Reply-To: <20021001201343.GB9551@kroah.com>
On Tuesday 01 October 2002 15:13, Greg KH wrote:
> On Tue, Oct 01, 2002 at 08:18:19AM -0500, Kevin Corry wrote:
> > If you have any additional comments, please let us know.
>
> There are still a large number of improper variable names, and quite a
> few typedefs throughout the kernel patch. I thought these were going to
> be fixed?
I had thought most of them were fixed as well.
Looking at the 2.5 code, I found one left-over typedef in ldev_mgr.c, which I
have just fixed. There are some in the cluster plugin (evms_ecr.c and
evms_ecr.h), but at the moment that is just a proposed clustering interface,
since there is no actual cluster support yet. It is likely those files will
change as the clustering support is added, so they will get cleaned up along
the way. The rest of the typedef's I'm seeing are all in the OS/2 and S/390
plugins, which as I mentioned in the first announcement haven't been ported
to 2.5 yet, and thus haven't gone through any cleanup. When those get ported
to 2.5, I'll make sure they are cleaned up.
As for improper variable names, can you give me a better idea of where you
are seeing them? Any specific examples?
> Also, is there any documentation on why the md code was reimplemented
> within evms, instead of using the existing kernel code?
It had to be reimplemented in order to fit into the plugin model in EVMS. We
had many requests from our users about a year ago to support the MD metadata,
so we added it by porting the existing MD kernel code to an EVMS plugin. Mike
Tran has been keeping up with Neil Brown's latest MD code for 2.5, in an
attempt to not greatly diverge the code. I believe Mike intends to talk with
Neil at some point about seeing if there is a way to provide a common set of
code/services that could be used by both MD and EVMS.
--
Kevin Corry
corryk@us.ibm.com
http://evms.sourceforge.net/
next prev parent reply other threads:[~2002-10-01 21:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-30 22:01 [ANNOUNCE] EVMS Release 1.2.0 Kevin Corry
2002-10-01 10:20 ` Jens Axboe
2002-10-01 13:18 ` Kevin Corry
2002-10-01 20:13 ` Greg KH
2002-10-01 21:19 ` Kevin Corry [this message]
2002-10-01 22:17 ` Greg KH
2002-10-02 13:06 ` Kevin Corry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02100116191001.20800@boiler \
--to=corryk@us.ibm.com \
--cc=evms-devel@lists.sourceforge.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).