linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Randy Dunlap <rdunlap@infradead.org>
Cc: "intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: RE: [PATCH] namespace: fix namespace.pl script to support relative paths
Date: Wed, 23 Oct 2019 21:34:06 +0000	[thread overview]
Message-ID: <02874ECE860811409154E81DA85FBB589693A38A@ORSMSX121.amr.corp.intel.com> (raw)
In-Reply-To: <CAK7LNARAhZtzdnS9+mgtamj=pLdV81dudnYVDa8NRxcQPpF0bw@mail.gmail.com>

> -----Original Message-----
> From: Masahiro Yamada <yamada.masahiro@socionext.com>
> Sent: Tuesday, October 22, 2019 10:22 PM
> To: Keller, Jacob E <jacob.e.keller@intel.com>; Randy Dunlap
> <rdunlap@infradead.org>
> Cc: intel-wired-lan@lists.osuosl.org; linux-kernel@vger.kernel.org; linux-kbuild
> <linux-kbuild@vger.kernel.org>
> Subject: Re: [PATCH] namespace: fix namespace.pl script to support relative
> paths
> 
> This scripts has been 5-year broken,
> and I did not see any complaint except from you.
> So, I wonder how many people are using this.
> 
> Nor, do I understand how to use it.
> 
> Could you teach me a bit more about this script?
> 
> 
> 
> Something might be missing in my mind, but
> I do not know how to use this script in a useful way.
> 
> 
> 
> It provides three checks.
> 
> [1] list_multiply_defined()
> 
> This warns multiple definition of functions.
> 
> The compiler would fail if it saw any multiple definition,
> so the reports from this check are all false-positive.
> 
> 
> [2] resolve_external_references()
> 
> This warns unresolved symbols.
> 
> The compiler would fail if it saw any unresolved symbol,
> so the reports from this check are all false-positive, too.
> 
> 

The compiler won't necessarily fail when building modules, because the symbol might be in another loadable module.

> 
> 
> [3] list_extra_externals
> 
> This warns symbols with no reference.
> 
> This potentially contains lots of false-positives.
> For example, the core framework provides APIs, but if all drivers
> are disabled, there is no user of those APIs.
> 

We use this to help verify that driver modules do not expose symbols.

Thanks,
Jake

  reply	other threads:[~2019-10-23 21:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29 20:43 [PATCH] namespace: fix namespace.pl script to support relative paths Jacob Keller
2019-09-27 23:12 ` Randy Dunlap
2019-09-27 23:23   ` Keller, Jacob E
2019-09-27 23:30   ` Keller, Jacob E
2019-09-29  0:20     ` Masahiro Yamada
2019-09-30 19:46       ` Keller, Jacob E
2019-10-23  5:21         ` Masahiro Yamada
2019-10-23 21:34           ` Keller, Jacob E [this message]
2019-10-24  1:21             ` Masahiro Yamada
2019-10-25 17:45               ` Keller, Jacob E
2019-10-25 19:30                 ` Randy Dunlap
2019-10-25 20:20                   ` Keller, Jacob E

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02874ECE860811409154E81DA85FBB589693A38A@ORSMSX121.amr.corp.intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).