From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>
Cc: <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>
Subject: RE: [PATCH v1 2/2] arm64: dts: exynos: keep LDO12 always-on
Date: Mon, 6 Jul 2020 21:23:49 +0530 [thread overview]
Message-ID: <02e601d653ad$a5734190$f059c4b0$@samsung.com> (raw)
In-Reply-To: <20200705182306.GA13827@kozik-lap>
Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 05 July 2020 23:53
> To: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org;
> robh+dt@kernel.org
> Subject: Re: [PATCH v1 2/2] arm64: dts: exynos: keep LDO12 always-on
>
> On Sun, Jul 05, 2020 at 12:39:18PM +0530, Alim Akhtar wrote:
> > LDO12 on exynos7 supply power to VDDQ_UFS20_RESET, in case this
> > regulator is OFF, UFS host controller can not send command to UFS
> > device. To keep this supply ON, set regulator-always-on property for
> > this ldo.
>
> Why UFS does not take any supplies? This looks like a workaround for the case
> of not implementing any consumer.
>
This particular supply is not part of UFS HCI spec and binding documentation, as per binding only one supply for host controller and three others for UFS device are needed. My best guess is, VDDQ_UFS20_RESET supply to reset logic block inside HCI, which might be specific to this controller version (I did not find any such supply in the latest host controller though).
> Best regards,
> Krzysztof
>
>
> >
> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> > ---
> > arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> > b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> > index bb86950032d3..92fecc539c6c 100644
> > --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> > +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> > @@ -194,6 +194,7 @@
> > regulator-min-microvolt = <1000000>;
> > regulator-max-microvolt = <1300000>;
> > regulator-enable-ramp-delay = <125>;
> > + regulator-always-on;
> > };
> >
> > ldo13_reg: LDO13 {
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2020-07-06 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200705072937epcas5p1b6c9a25770451bcb9d8bc5b14b8a8b53@epcas5p1.samsung.com>
2020-07-05 7:09 ` [PATCH v1 1/2] arm64: dts: exynos: Fix silent hang after boot Alim Akhtar
[not found] ` <CGME20200705072938epcas5p479f0d040ca34fd44b2ba893a199efb79@epcas5p4.samsung.com>
2020-07-05 7:09 ` [PATCH v1 2/2] arm64: dts: exynos: keep LDO12 always-on Alim Akhtar
2020-07-05 18:23 ` Krzysztof Kozlowski
2020-07-06 15:53 ` Alim Akhtar [this message]
2020-07-07 6:40 ` 'Krzysztof Kozlowski'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='02e601d653ad$a5734190$f059c4b0$@samsung.com' \
--to=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).