From: Joe Perches <joe@perches.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Markus Elfring <Markus.Elfring@web.de>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Colin Ian King <colin.king@canonical.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: mmc: atmel-mci: Reduce scope for the variable “slot” in atmci_request_end()
Date: Sat, 12 Dec 2020 10:48:55 -0800 [thread overview]
Message-ID: <03bb4d4436ca7022effbf23551ada24ff9eeb4c6.camel@perches.com> (raw)
In-Reply-To: <20201212131727.GL1781038@piout.net>
On Sat, 2020-12-12 at 14:17 +0100, Alexandre Belloni wrote:
> On 12/12/2020 01:16:39-0800, Joe Perches wrote:
> > In this case Alexandre it seems true, but in the generic case
> > it may be false. It may depend on stack size and location.
> >
> > For instance, with large structs declared either at the top
> > of a function or in separate branches within the function:
>
> I think you realize your example is way more complicated than
> initializing basic type variable to 0 or NULL which has probably been
> optimized forever.
Maybe.
Markus does a lot of what most (or perhaps some) consider thoughtless.
A generic point might be maximizing the local scope of declarations.
Maximizing the local scope can make reading easier as the type of an
automatic used for a temporary purpose can be found closer to the code
that uses it. This is especially true for long line-count functions.
IMO: it's a reasonable goal though in this instance perhaps unnecessary.
cheers, Joe
next prev parent reply other threads:[~2020-12-12 18:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <466b4c6d-032f-fbcc-58ac-75f6f39d734f@web.de>
2020-12-10 15:10 ` [PATCH] mmc: atmel-mci: Reduce scope for the variable “slot” in atmci_request_end() Alexandre Belloni
[not found] ` <ec71d7b8-a36b-04f5-77a8-22874ac241e1@web.de>
2020-12-10 17:07 ` Alexandre Belloni
[not found] ` <2667790c-fad2-aaa9-36e8-6be66949ac8d@web.de>
2020-12-10 18:21 ` Alexandre Belloni
[not found] ` <4c0d8efe-de25-f168-8b8d-b7f1ede6c6b1@web.de>
2020-12-11 8:03 ` Alexandre Belloni
2020-12-12 9:16 ` Joe Perches
2020-12-12 13:17 ` Alexandre Belloni
2020-12-12 18:48 ` Joe Perches [this message]
2020-12-11 8:37 ` [PATCH] " Dan Carpenter
[not found] ` <e7910b04-4c4a-567b-d87d-d12352a48cfc@web.de>
2020-12-14 7:05 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03bb4d4436ca7022effbf23551ada24ff9eeb4c6.camel@perches.com \
--to=joe@perches.com \
--cc=Markus.Elfring@web.de \
--cc=alexandre.belloni@bootlin.com \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).