From: Oliver Hartkopp <socketcan@hartkopp.net>
To: maowenan <maowenan@huawei.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net: can: Fix compiling warning
Date: Mon, 12 Aug 2019 10:11:11 +0200 [thread overview]
Message-ID: <04055e63-c2c0-78e3-1b24-47be08976750@hartkopp.net> (raw)
In-Reply-To: <5018f6ca-53b5-c712-a012-a0fcda5c10c2@huawei.com>
On 12/08/2019 07.48, maowenan wrote:
> On 2019/8/7 0:41, Oliver Hartkopp wrote:
>> I compiled the code (the original version), but I do not get that "Should it be static?" warning:
> here are my steps for net/can/bcm.c,
> make allmodconfig ARCH=mips CROSS_COMPILE=mips-linux-gnu-
> make C=2 net/can/bcm.o ARCH=mips CROSS_COMPILE=mips-linux-gnu-
There were some sparse _errors_ in my setup that hide that "static"
warning. I will use sparse by default now.
Many thanks,
Oliver
next prev parent reply other threads:[~2019-08-12 8:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 3:36 [PATCH net-next] net: can: Fix compiling warning Mao Wenan
2019-08-02 8:10 ` Oliver Hartkopp
2019-08-02 8:39 ` maowenan
2019-08-06 13:52 ` Dan Carpenter
2019-08-06 16:41 ` Oliver Hartkopp
2019-08-07 10:50 ` Dan Carpenter
2019-08-12 17:19 ` Kees Cook
2019-08-13 12:48 ` Dan Carpenter
2019-08-12 5:48 ` maowenan
2019-08-12 8:11 ` Oliver Hartkopp [this message]
2019-08-02 8:59 ` Sergei Shtylyov
2019-08-05 1:13 ` maowenan
2019-08-05 1:26 ` [PATCH net-next v2] " Mao Wenan
2019-08-05 10:56 ` [v2] " Markus Elfring
2019-08-05 11:57 ` [PATCH net-next v3] net: can: Fix compiling warnings for two functions Mao Wenan
2019-08-05 17:30 ` David Miller
2019-08-06 1:37 ` [PATCH net-next v4] " Mao Wenan
2019-08-06 11:37 ` [v4] " Markus Elfring
2019-08-06 14:40 ` [PATCH net-next v5] net: can: Fix sparse " Mao Wenan
2019-08-05 1:22 [PATCH net-next] net: can: Fix compiling warning Mao Wenan
2019-08-05 1:22 ` maowenan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04055e63-c2c0-78e3-1b24-47be08976750@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maowenan@huawei.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).