From: Arnaud POULIQUEN <arnaud.pouliquen@foss.st.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
<linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH 2/4] rpmsg: ctrl: Introduce RPMSG_RELEASE_DEV_IOCTL
Date: Wed, 16 Jun 2021 10:13:52 +0200 [thread overview]
Message-ID: <0465abac-1526-bf6b-605d-9f29145f3f58@foss.st.com> (raw)
In-Reply-To: <20210615173844.GA604521@p14s>
On 6/15/21 7:38 PM, Mathieu Poirier wrote:
> Good day,
>
> On Fri, Jun 04, 2021 at 11:14:04AM +0200, Arnaud Pouliquen wrote:
>> Implement the RPMSG_RELEASE_DEV_IOCTL to allow the user application to
>> release a rpmsg device created either by the remote processor or with
>> the RPMSG_CREATE_DEV_IOCTL call.
>> Depending on the back-end implementation, the associated rpmsg driver is
>> removed and a NS destroy rpmsg can be sent to the remote processor.
>>
>> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
>> ---
>> drivers/rpmsg/rpmsg_ctrl.c | 7 +++++++
>> include/uapi/linux/rpmsg.h | 5 +++++
>> 2 files changed, 12 insertions(+)
>>
>> diff --git a/drivers/rpmsg/rpmsg_ctrl.c b/drivers/rpmsg/rpmsg_ctrl.c
>> index 4aa962df3661..cb19e32d05e1 100644
>> --- a/drivers/rpmsg/rpmsg_ctrl.c
>> +++ b/drivers/rpmsg/rpmsg_ctrl.c
>> @@ -98,6 +98,13 @@ static long rpmsg_ctrldev_ioctl(struct file *fp, unsigned int cmd,
>> }
>> break;
>>
>> + case RPMSG_RELEASE_DEV_IOCTL:
>> + ret = rpmsg_release_channel(ctrldev->rpdev, &chinfo);
>> + if (ret)
>> + dev_err(&ctrldev->dev, "failed to release %s channel (%d)\n",
>> + chinfo.name, ret);
>> + break;
>> +
>
> Please move the content of this patch in 1/4.
ok
>
>> default:
>> ret = -EINVAL;
>> }
>> diff --git a/include/uapi/linux/rpmsg.h b/include/uapi/linux/rpmsg.h
>> index f9d5a74e7801..38639ba37438 100644
>> --- a/include/uapi/linux/rpmsg.h
>> +++ b/include/uapi/linux/rpmsg.h
>> @@ -38,4 +38,9 @@ struct rpmsg_endpoint_info {
>> */
>> #define RPMSG_CREATE_DEV_IOCTL _IOW(0xb5, 0x3, struct rpmsg_endpoint_info)
>>
>> +/**
>> + * Release a local rpmsg device.
>> + */
>> +#define RPMSG_RELEASE_DEV_IOCTL _IOW(0xb5, 0x4, struct rpmsg_endpoint_info)
>> +
>> #endif
>> --
>> 2.17.1
>>
next prev parent reply other threads:[~2021-06-16 8:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 9:14 [PATCH 0/4] rpmsg: ctrl: Add ability to instantiate rpmsg device locally Arnaud Pouliquen
2021-06-04 9:14 ` [PATCH 1/4] rpmsg: ctrl: Introduce RPMSG_CREATE_DEV_IOCTL Arnaud Pouliquen
2021-06-15 17:53 ` Mathieu Poirier
2021-06-16 8:12 ` Arnaud POULIQUEN
2021-06-21 9:35 ` Arnaud POULIQUEN
2021-06-04 9:14 ` [PATCH 2/4] rpmsg: ctrl: Introduce RPMSG_RELEASE_DEV_IOCTL Arnaud Pouliquen
2021-06-15 17:38 ` Mathieu Poirier
2021-06-16 8:13 ` Arnaud POULIQUEN [this message]
2021-06-04 9:14 ` [PATCH 3/4] rpmsg: ctrl: Add check on rpmsg device removability from user space Arnaud Pouliquen
2021-06-15 17:46 ` Mathieu Poirier
2021-06-16 9:30 ` Arnaud POULIQUEN
2021-06-16 17:15 ` Mathieu Poirier
2021-06-17 8:02 ` Arnaud POULIQUEN
2021-06-17 16:55 ` Arnaud POULIQUEN
2021-06-17 16:56 ` Mathieu Poirier
2021-06-04 9:14 ` [PATCH 4/4] rpmsg: Add a removable attribute to the rpmsg device Arnaud Pouliquen
2021-06-15 17:48 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0465abac-1526-bf6b-605d-9f29145f3f58@foss.st.com \
--to=arnaud.pouliquen@foss.st.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).