From: Tim Chen <tim.c.chen@linux.intel.com>
To: Yicong Yang <yangyicong@hisilicon.com>,
peterz@infradead.org, mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, gautham.shenoy@amd.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, bristot@redhat.com, prime.zeng@huawei.com,
jonathan.cameron@huawei.com, ego@linux.vnet.ibm.com,
srikar@linux.vnet.ibm.com, linuxarm@huawei.com,
21cnbao@gmail.com, guodong.xu@linaro.org,
hesham.almatary@huawei.com, john.garry@huawei.com,
shenyang39@huawei.com
Subject: Re: [PATCH v4 1/2] sched: Add per_cpu cluster domain info and cpus_share_resources API
Date: Thu, 09 Jun 2022 15:28:38 -0700 [thread overview]
Message-ID: <05472b4ed10c694bce1a2b6dd4a0ef13ea337db3.camel@linux.intel.com> (raw)
In-Reply-To: <20220609120622.47724-2-yangyicong@hisilicon.com>
On Thu, 2022-06-09 at 20:06 +0800, Yicong Yang wrote:
>
>
> +/*
> + * Whether CPUs are share cache resources, which means LLC on non-cluster
> + * machines and LLC tag or L2 on machines with clusters.
> + */
> +bool cpus_share_resources(int this_cpu, int that_cpu)
Suggest cpus_share_lowest_cache to be a bit more informative
> +{
> + if (this_cpu == that_cpu)
> + return true;
> +
> + return per_cpu(sd_share_id, this_cpu) == per_cpu(sd_share_id, that_cpu);
> +}
> +
> static inline bool ttwu_queue_cond(int cpu, int wake_flags)
> {
> /*
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 01259611beb9..b9bcfcf8d14d 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -1753,7 +1753,9 @@ static inline struct sched_domain *lowest_flag_domain(int cpu, int flag)
> DECLARE_PER_CPU(struct sched_domain __rcu *, sd_llc);
> DECLARE_PER_CPU(int, sd_llc_size);
> DECLARE_PER_CPU(int, sd_llc_id);
> +DECLARE_PER_CPU(int, sd_share_id);
> DECLARE_PER_CPU(struct sched_domain_shared __rcu *, sd_llc_shared);
> +DECLARE_PER_CPU(struct sched_domain __rcu *, sd_cluster);
> DECLARE_PER_CPU(struct sched_domain __rcu *, sd_numa);
> DECLARE_PER_CPU(struct sched_domain __rcu *, sd_asym_packing);
> DECLARE_PER_CPU(struct sched_domain __rcu *, sd_asym_cpucapacity);
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 05b6c2ad90b9..0595827d481d 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -664,6 +664,8 @@ static void destroy_sched_domains(struct sched_domain *sd)
> DEFINE_PER_CPU(struct sched_domain __rcu *, sd_llc);
> DEFINE_PER_CPU(int, sd_llc_size);
> DEFINE_PER_CPU(int, sd_llc_id);
> +DEFINE_PER_CPU(int, sd_share_id);
Some minor nits about the name of "sd_share_id".
It is not quite obvious what it is.
Maybe something like sd_lowest_cache_id to denote
it is the id of lowest shared cache domain between CPU.
Otherwise the patch looks good to me. You can add
Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>
Tim
next prev parent reply other threads:[~2022-06-09 22:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 12:06 [PATCH v4 0/2] sched/fair: Wake task within the cluster when possible Yicong Yang
2022-06-09 12:06 ` [PATCH v4 1/2] sched: Add per_cpu cluster domain info and cpus_share_resources API Yicong Yang
2022-06-09 22:28 ` Tim Chen [this message]
2022-06-10 6:54 ` Yicong Yang
2022-06-15 14:19 ` K Prateek Nayak
2022-06-15 15:43 ` Gautham R. Shenoy
2022-06-16 8:10 ` Yicong Yang
2022-06-16 7:55 ` Yicong Yang
2022-06-17 12:20 ` K Prateek Nayak
2022-06-17 16:50 ` Tim Chen
2022-06-20 11:20 ` K Prateek Nayak
2022-06-20 13:37 ` Abel Wu
2022-06-28 11:55 ` K Prateek Nayak
2022-06-29 3:22 ` Yicong Yang
2022-06-09 12:06 ` [PATCH v4 2/2] sched/fair: Scan cluster before scanning LLC in wake-up path Yicong Yang
2022-06-09 22:47 ` Tim Chen
2022-06-10 4:01 ` Barry Song
2022-06-10 6:39 ` Yicong Yang
2022-06-10 21:19 ` Tim Chen
2022-06-11 3:03 ` Chen Yu
2022-06-11 7:40 ` Yicong Yang
2022-06-11 9:04 ` Chen Yu
2022-06-26 12:13 ` Abel Wu
2022-06-27 8:16 ` Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05472b4ed10c694bce1a2b6dd4a0ef13ea337db3.camel@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=21cnbao@gmail.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=ego@linux.vnet.ibm.com \
--cc=gautham.shenoy@amd.com \
--cc=guodong.xu@linaro.org \
--cc=hesham.almatary@huawei.com \
--cc=john.garry@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=juri.lelli@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=prime.zeng@huawei.com \
--cc=rostedt@goodmis.org \
--cc=shenyang39@huawei.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=vincent.guittot@linaro.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).