From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>,
"JBottomley@odin.com" <JBottomley@odin.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"tyreld@linux.vnet.ibm.com" <tyreld@linux.vnet.ibm.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"mchehab@osg.samsung.com" <mchehab@osg.samsung.com>,
"jslaby@suse.com" <jslaby@suse.com>,
"joe@perches.com" <joe@perches.com>, "bp@suse.de" <bp@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
bgly <bgly@us.ibm.com>
Subject: Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver
Date: Tue, 24 May 2016 09:44:43 -0700 [thread overview]
Message-ID: <05554b20-46af-5298-e822-9d8bcba6b096@sandisk.com> (raw)
In-Reply-To: <20160524163411.GA21800@kroah.com>
On 05/24/2016 09:34 AM, Greg KH wrote:
> On Tue, May 24, 2016 at 09:25:05AM -0700, Bart Van Assche wrote:
>>> +static inline long h_send_crq(struct ibmvscsis_adapter *adapter,
>>> + u64 word1, u64 word2)
>>> +{
>>> + long rc;
>>> + struct vio_dev *vdev = adapter->dma_dev;
>>> +
>>> + pr_debug("ibmvscsis: ibmvscsis_send_crq(0x%x, 0x%016llx, 0x%016llx)\n",
>>> + vdev->unit_address, word1, word2);
>>> +
>>
>> As Joe Perches already asked, please define pr_fmt() instead of including
>> the kernel module name in every pr_debug() statement.
>
> Even better, as this is a driver, it should be using dev_*() calls
> instead of pr_*() calls to properly identify the device and driver that
> is making the message. No driver should be using pr_*() except in
> _very_ limited usages.
Hi Greg,
The reason I recommended pr_debug() is because ibmvscsis is a LIO target
driver and I don't think a struct device is associated with a LIO target
driver. See e.g. target_register_template() in
drivers/target/target_core_configfs.c.
Bart.
next prev parent reply other threads:[~2016-05-24 16:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 13:52 [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver Bryant G. Ly
2016-05-24 14:14 ` Joe Perches
2016-05-24 14:30 ` Greg KH
2016-05-24 16:25 ` Bart Van Assche
2016-05-24 16:34 ` Greg KH
2016-05-24 16:44 ` Bart Van Assche [this message]
2016-05-24 16:50 ` Greg KH
2016-05-24 20:00 ` Bryant G Ly
2016-06-10 19:03 ` Bart Van Assche
2016-06-14 6:23 ` Nicholas A. Bellinger
2016-06-14 14:55 ` Christoph Hellwig
2016-05-25 14:17 ` IBM VSCSI Target Driver Initial Patch Sets Bryant G. Ly
2016-05-25 14:17 ` [PATCH 2/3] ibmvscsis: Addressing Bart's comments Bryant G. Ly
2016-05-25 14:17 ` [PATCH 3/3] ibmvscsis: clean up functions Bryant G. Ly
2016-05-25 14:44 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05554b20-46af-5298-e822-9d8bcba6b096@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=JBottomley@odin.com \
--cc=akpm@linux-foundation.org \
--cc=bgly@us.ibm.com \
--cc=bp@suse.de \
--cc=bryantly@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=jslaby@suse.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchehab@osg.samsung.com \
--cc=target-devel@vger.kernel.org \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).