From: Hans Verkuil <hverkuil@xs4all.nl>
To: Eddie James <eajames@linux.vnet.ibm.com>,
Eddie James <eajames@linux.ibm.com>,
linux-kernel@vger.kernel.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-aspeed@lists.ozlabs.org, andrew@aj.id.au,
openbmc@lists.ozlabs.org, robh+dt@kernel.org, mchehab@kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v3 0/2] media: platform: Add Aspeed Video Engine Driver
Date: Fri, 28 Sep 2018 13:29:44 +0200 [thread overview]
Message-ID: <057866e9-5d37-f2db-86a3-aa726b23dad2@xs4all.nl> (raw)
In-Reply-To: <f033e988-e46f-b232-8ea5-a287cd48ef84@linux.vnet.ibm.com>
On 09/26/2018 08:05 PM, Eddie James wrote:
>
>
> On 09/26/2018 07:03 AM, Hans Verkuil wrote:
>> On 09/25/2018 09:27 PM, Eddie James wrote:
>>> The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs
>>> can capture and compress video data from digital or analog sources. With
>>> the Aspeed chip acting as a service processor, the Video Engine can
>>> capture the host processor graphics output.
>>>
>>> This series adds a V4L2 driver for the VE, providing the usual V4L2 streaming
>>> interface by way of videobuf2. Each frame, the driver triggers the hardware to
>>> capture the host graphics output and compress it to JPEG format.
>>>
>>> I was unable to cross compile v4l2-compliance for ARM with our OpenBMC
>>> toolchain. Although bootstrap, configure, and make were successful, no binaries
>>> were generated... I was able to build v4l-utils 1.12.3 from the OpenEmbedded
>>> project, with the output below:
>> You can also try to build it manually:
>>
>> g++ -o v4l2-compliance -DNO_LIBV4L2 v4l2-compliance.cpp v4l2-test-debug.cpp v4l2-test-input-output.cpp v4l2-test-controls.cpp v4l2-test-io-config.cpp v4l2-test-formats.cpp v4l2-test-buffers.cpp
>> v4l2-test-codecs.cpp v4l2-test-colors.cpp v4l2-test-media.cpp v4l2-test-subdevs.cpp media-info.cpp v4l2-info.cpp -I../.. -I../../include -I../common
>>
>> (replace g++ with your cross compiler)
>>
>> Hopefully that will work since 1.12.3 is way too old.
>>
>> Regards,
>>
>> Hans
>
> Yea I got it built. Still no SHA :( But this is with HEAD at commit 3874aa8eb1ff0c2e103d024ba5af915b1b26f098
>
> FYI I am also patching out the JPEG thing I mentioned, so that the streaming test will run:
> diff --git a/utils/v4l2-compliance/v4l2-test-formats.cpp b/utils/v4l2-compliance
> index 02c2ce9..1f6eaa5 100644
> --- a/utils/v4l2-compliance/v4l2-test-formats.cpp
> +++ b/utils/v4l2-compliance/v4l2-test-formats.cpp
> @@ -330,7 +330,7 @@ static int testColorspace(__u32 pixelformat, __u32 colorspac
> fail_on_test(!colorspace);
> fail_on_test(colorspace == V4L2_COLORSPACE_BT878);
> fail_on_test(pixelformat == V4L2_PIX_FMT_JPEG &&
> - colorspace != V4L2_COLORSPACE_JPEG);
> + colorspace != V4L2_COLORSPACE_SRGB);
I dropped this bogus test from v4l2-compliance. It doesn't make sense.
Regards,
Hans
next prev parent reply other threads:[~2018-09-28 11:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 19:27 [PATCH v3 0/2] media: platform: Add Aspeed Video Engine Driver Eddie James
2018-09-25 19:27 ` [PATCH v3 1/2] dt-bindings: media: Add Aspeed Video Engine binding documentation Eddie James
2018-09-27 19:54 ` Rob Herring
2018-10-01 13:08 ` Joel Stanley
2018-10-01 15:20 ` Eddie James
2018-09-25 19:27 ` [PATCH v3 2/2] media: platform: Add Aspeed Video Engine driver Eddie James
2018-09-28 11:30 ` Hans Verkuil
2018-09-28 16:06 ` Eddie James
2018-10-03 20:26 ` Eddie James
2018-10-04 13:02 ` Hans Verkuil
2018-10-03 20:43 ` Eddie James
2018-10-04 13:12 ` Hans Verkuil
2018-10-05 20:03 ` Eddie James
2018-09-26 12:03 ` [PATCH v3 0/2] media: platform: Add Aspeed Video Engine Driver Hans Verkuil
2018-09-26 18:05 ` Eddie James
2018-09-28 11:29 ` Hans Verkuil [this message]
2018-09-28 11:45 ` Hans Verkuil
2018-09-28 16:09 ` Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=057866e9-5d37-f2db-86a3-aa726b23dad2@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=eajames@linux.vnet.ibm.com \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).