From: IgorMitsyanko <igor.mitsyanko.os@quantenna.com>
To: "Felix Fietkau" <nbd@nbd.name>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Linus Lüssing" <linus.luessing@c0d3.blue>,
"Stephen Hemminger" <stephen@networkplumber.org>
Cc: <netdev@vger.kernel.org>, <bridge@lists.linux-foundation.org>,
<linux-wireless@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"M. Braun" <michael-dev@fami-braun.de>
Subject: Re: [PATCH net-next] bridge: multicast to unicast
Date: Wed, 11 Jan 2017 14:26:16 +0300 [thread overview]
Message-ID: <058f2afd-2502-e2e5-6427-1536fcd5851f@quantenna.com> (raw)
In-Reply-To: <73f29777-cf95-de99-f7a9-9d82e94c298d@nbd.name>
On 01/11/2017 12:27 AM, Felix Fietkau wrote:
> On 2017-01-10 11:56, Johannes Berg wrote:
>> On Tue, 2017-01-10 at 05:18 +0100, Linus Lüssing wrote:
>>> On Mon, Jan 09, 2017 at 01:30:32PM -0800, Stephen Hemminger wrote:
>>>> I wonder if MAC80211 should be doing IGMP snooping and not bridge
>>>> in this environment.
>>>
>>> In the long term, yes. For now, not quite sure.
>>
>> There's no "for now" in the kernel. Code added now will have to be
>> maintained essentially forever.
> I'm not sure that putting the IGMP snooping code in mac80211 is a good
> idea, that would be quite a bit of code duplication.
> This implementation works, it's very simple, and it's quite flexible for
> a number of use cases.
>
> Is there any remaining objection to merging this in principle (aside
> from potential issues with the code)?
>
> - Felix
>
Hi Felix, can we consider two examples configurations with multicast
traffic:
1. AP is a source of multicast traffic itself, no bridge on AP. For
example, wireless video server streaming to several clients.
In this situation, we can not make use of possible advantages given by
mc-to-uc conversion?
2. A configuration with AP + STA + 3 client devices behind STA.
----|client 1|
|
| mc |----|AP|----|STA|---|---|client 2|
|server| |
----|client 3|
Multicast server behind AP streams MC video traffic. All 3 clients
behind the STA have joined the multicast group.
I'm not sure if this case will be handled correctly with mc-to-uc
conversion in bridge on AP?
next prev parent reply other threads:[~2017-01-11 11:26 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 19:32 [PATCH net-next] bridge: multicast to unicast Linus Lüssing
2017-01-03 11:58 ` Nikolay Aleksandrov
2017-01-03 13:15 ` Felix Fietkau
2017-01-06 12:47 ` Johannes Berg
2017-01-06 13:52 ` Felix Fietkau
2017-01-06 13:54 ` Johannes Berg
2017-01-06 13:54 ` Felix Fietkau
2017-01-07 10:32 ` M. Braun
2017-01-07 14:55 ` Linus Lüssing
2017-01-09 8:08 ` Johannes Berg
2017-01-09 11:44 ` M. Braun
2017-01-09 12:15 ` Johannes Berg
2017-01-09 15:25 ` michael-dev
2017-01-09 15:47 ` Johannes Berg
2017-01-09 21:23 ` Linus Lüssing
2017-01-09 21:30 ` Stephen Hemminger
2017-01-10 4:18 ` Linus Lüssing
2017-01-10 10:56 ` Johannes Berg
2017-01-10 17:17 ` Dave Taht
2017-01-10 17:23 ` Felix Fietkau
2017-01-10 18:24 ` Dave Taht
2017-01-10 21:27 ` Felix Fietkau
2017-01-11 11:26 ` IgorMitsyanko [this message]
2017-01-11 11:30 ` Felix Fietkau
2017-01-11 12:15 ` IgorMitsyanko
2017-01-11 12:21 ` Felix Fietkau
2017-01-07 15:15 ` Linus Lüssing
2017-01-09 8:05 ` Johannes Berg
2017-01-09 12:42 ` Linus Lüssing
2017-01-09 12:44 ` Johannes Berg
2017-01-09 23:12 ` Linus Lüssing
2017-01-11 9:17 ` Johannes Berg
2017-01-07 3:13 ` Stephen Hemminger
2017-01-07 15:06 ` Linus Lüssing
2017-01-09 8:36 ` Jean-Pierre Tosoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=058f2afd-2502-e2e5-6427-1536fcd5851f@quantenna.com \
--to=igor.mitsyanko.os@quantenna.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linus.luessing@c0d3.blue \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michael-dev@fami-braun.de \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).