From: Alex Shi <alex.shi@linux.alibaba.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/bluetooth: remove __get_channel/dir
Date: Tue, 4 Feb 2020 19:28:07 +0800 [thread overview]
Message-ID: <09359312-a1c8-c560-85ba-0f94be521b26@linux.alibaba.com> (raw)
In-Reply-To: <8CA3EF63-F688-48B2-A21D-16FDBC809EDE@holtmann.org>
在 2020/1/22 上午12:19, Marcel Holtmann 写道:
> Hi Alex,
>
>> These 2 macros are never used from first git commit Linux-2.6.12-rc2. So
>> better to remove them.
>>
>> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
>> Cc: Marcel Holtmann <marcel@holtmann.org>
>> Cc: Johan Hedberg <johan.hedberg@gmail.com>
>> Cc: "David S. Miller" <davem@davemloft.net>
>> Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
>> Cc: linux-bluetooth@vger.kernel.org
>> Cc: netdev@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> ---
>> net/bluetooth/rfcomm/core.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/net/bluetooth/rfcomm/core.c b/net/bluetooth/rfcomm/core.c
>> index 3a9e9d9670be..825adff79f13 100644
>> --- a/net/bluetooth/rfcomm/core.c
>> +++ b/net/bluetooth/rfcomm/core.c
>> @@ -73,8 +73,6 @@ static struct rfcomm_session *rfcomm_session_create(bdaddr_t *src,
>>
>> /* ---- RFCOMM frame parsing macros ---- */
>> #define __get_dlci(b) ((b & 0xfc) >> 2)
>> -#define __get_channel(b) ((b & 0xf8) >> 3)
>> -#define __get_dir(b) ((b & 0x04) >> 2)
>> #define __get_type(b) ((b & 0xef))
>>
>> #define __test_ea(b) ((b & 0x01))
>
> it seems we are also not using __dir macro either.
>
Hi Marcel,
Thanks a lot for reminder. How about the following patch?
Thanks
Alex
From 41ef02c2f52cee1d69bb0ba0fbd90247d61dc155 Mon Sep 17 00:00:00 2001
From: Alex Shi <alex.shi@linux.alibaba.com>
Date: Wed, 15 Jan 2020 17:11:01 +0800
Subject: [PATCH v2] net/bluetooth: remove __get_channel/dir and __dir
These 3 macros are never used from first git commit Linux-2.6.12-rc2.
let's remove them.
Suggested-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: linux-bluetooth@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
net/bluetooth/rfcomm/core.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/bluetooth/rfcomm/core.c b/net/bluetooth/rfcomm/core.c
index 3a9e9d9670be..dcecce087b24 100644
--- a/net/bluetooth/rfcomm/core.c
+++ b/net/bluetooth/rfcomm/core.c
@@ -73,8 +73,6 @@ static struct rfcomm_session *rfcomm_session_create(bdaddr_t *src,
/* ---- RFCOMM frame parsing macros ---- */
#define __get_dlci(b) ((b & 0xfc) >> 2)
-#define __get_channel(b) ((b & 0xf8) >> 3)
-#define __get_dir(b) ((b & 0x04) >> 2)
#define __get_type(b) ((b & 0xef))
#define __test_ea(b) ((b & 0x01))
@@ -87,7 +85,6 @@ static struct rfcomm_session *rfcomm_session_create(bdaddr_t *src,
#define __ctrl(type, pf) (((type & 0xef) | (pf << 4)))
#define __dlci(dir, chn) (((chn & 0x1f) << 1) | dir)
#define __srv_channel(dlci) (dlci >> 1)
-#define __dir(dlci) (dlci & 0x01)
#define __len8(len) (((len) << 1) | 1)
#define __len16(len) ((len) << 1)
--
1.8.3.1
next prev parent reply other threads:[~2020-02-04 11:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 8:49 [PATCH] net/bluetooth: remove __get_channel/dir Alex Shi
2020-01-21 16:19 ` Marcel Holtmann
2020-02-04 11:28 ` Alex Shi [this message]
2020-02-04 14:58 ` Marcel Holtmann
2020-02-05 3:23 ` [PATCH v2] net/bluetooth: remove __get_channel/dir and __dir Alex Shi
2020-02-05 8:08 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09359312-a1c8-c560-85ba-0f94be521b26@linux.alibaba.com \
--to=alex.shi@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).