From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A3F7C76186 for ; Tue, 30 Jul 2019 00:47:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CE5820651 for ; Tue, 30 Jul 2019 00:47:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="Z+4FES9i"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="dnRyJRVy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730247AbfG3Ari (ORCPT ); Mon, 29 Jul 2019 20:47:38 -0400 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:45989 "EHLO new3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728845AbfG3Ari (ORCPT ); Mon, 29 Jul 2019 20:47:38 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id D3E0419F0; Mon, 29 Jul 2019 20:47:36 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute4.internal (MEProxy); Mon, 29 Jul 2019 20:47:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=eUppwzne5DrVof21J5/gklNPyLRad5M JnS92CT4MQOE=; b=Z+4FES9iZq1wf2GBvACLZOc8FlD2Ry8UqaydVs/XfE+JfS6 glicnxZYi8fePwRUzXQclQ98Yy1n/t2gPumBGaYmTtzjdDQzjp7SpM7EQfjR3+ly 7bw1TLwcCET0wWieAEyZaw/GNvjCPJ/yXyjvEFpeKF6NK0JV7g1PSnOVA1ou3Cmj 0rW0lIbSfqhPXAp1PZApFDtQ4Cnm4CBH6Fzdih1GDY6i9plrpa1IhQ2fVQyKQkSm RVqYGHwqeyXFuxH0FoLDp4A9BxcbyfddKcRC3n6BDSfaafmzq+zk8ri0MdwmH7AM H7Ana0pmzF1Oid8QQ2c6/xMrdFlT4bEE2fZHksA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=eUppwz ne5DrVof21J5/gklNPyLRad5MJnS92CT4MQOE=; b=dnRyJRVysc2TF41LsiKd5S 9Eb4WiB0ID8ucuIpmdGU1FCf+ci0FzLmnOULTDWELW2VjtlIu4MyzNvjoPm8sgNM 8djVrb6ZTw9/oUymjNTD2PdJl9uE2zOQtlITkMQqHC2IwgJtUk2WqjlLqREkikYn gEVHok7Wy6r/UoweHEMhLjGcQaAfR591Gwc6fDgDndP2h4ZntSyGfs8eH9B+fd4i KR4VjnO9cYeH42tS3EaVuU1PfQNUUaxllGFEvFw19dk/B/LjQ8lnegIH7z61kBQx wSHcrHDYSfORvB2jpJtPZfd4/kgT1nviraXUz/gc+9DYzA+cBUoHLkDSSr/djq4Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrledvgdefkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehnughr vgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucffohhmrg hinhepuggvvhhitggvthhrvggvrdhorhhgpdihrghmlhdrshhonecurfgrrhgrmhepmhgr ihhlfhhrohhmpegrnhgurhgvfiesrghjrdhiugdrrghunecuvehluhhsthgvrhfuihiivg eptd X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id E72F8E00A2; Mon, 29 Jul 2019 20:47:34 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.6-736-gdfb8e44-fmstable-20190718v2 Mime-Version: 1.0 Message-Id: <097bdf8e-4409-4c23-8c4c-d50e16d952dc@www.fastmail.com> In-Reply-To: References: <20190729043926.32679-1-andrew@aj.id.au> <20190729043926.32679-2-andrew@aj.id.au> Date: Tue, 30 Jul 2019 10:17:54 +0930 From: "Andrew Jeffery" To: "Rob Herring" Cc: netdev , "David Miller" , "Mark Rutland" , "Joel Stanley" , "Andrew Lunn" , "Florian Fainelli" , "Heiner Kallweit" , devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-aspeed@lists.ozlabs.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/4] dt-bindings: net: Add aspeed,ast2600-mdio binding Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Jul 2019, at 09:07, Rob Herring wrote: > On Sun, Jul 28, 2019 at 10:39 PM Andrew Jeffery wrote: > > > > The AST2600 splits out the MDIO bus controller from the MAC into its own > > IP block and rearranges the register layout. Add a new binding to > > describe the new hardware. > > > > Signed-off-by: Andrew Jeffery > > --- > > .../bindings/net/aspeed,ast2600-mdio.yaml | 61 +++++++++++++++++++ > > 1 file changed, 61 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml > > new file mode 100644 > > index 000000000000..fa86f6438473 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml > > @@ -0,0 +1,61 @@ > > +# SPDX-License-Identifier: GPL-2.0-or-later > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/aspeed,ast2600-mdio.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ASPEED AST2600 MDIO Controller > > + > > +maintainers: > > + - Andrew Jeffery > > + > > +description: |+ > > + The ASPEED AST2600 MDIO controller is the third iteration of ASPEED's MDIO > > + bus register interface, this time also separating out the controller from the > > + MAC. > > + > > Should have a: > > allOf: > - $ref: "mdio.yaml#" Ack. > > > +properties: > > + compatible: > > + const: aspeed,ast2600-mdio > > + reg: > > + maxItems: 1 > > + description: The register range of the MDIO controller instance > > > + "#address-cells": > > + const: 1 > > + "#size-cells": > > + const: 0 > > Then you can drop these 2. Great. > > > + > > +patternProperties: > > + "^ethernet-phy@[a-f0-9]$": > > + properties: > > + reg: > > + description: > > + The MDIO bus index of the PHY > > And this. > > > + compatible: > > + enum: > > + - ethernet-phy-ieee802.3-c22 > > + - ethernet-phy-ieee802.3-c45 > > This isn't specific to ASpeed either and is already covered by > ethernet-phy.yaml. > > So that means none of the child node schema is needed here. Bah, I'd developed the patches on v5.2 while waiting for v5.3-rc1 to come out. > > > + required: > > + - reg > > + > > +required: > > + - compatible > > + - reg > > + - "#address-cells" > > + - "#size-cells" > > + > > +examples: > > + - | > > + mdio0: mdio@1e650000 { > > + compatible = "aspeed,ast2600-mdio"; > > + reg = <0x1e650000 0x8>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + status = "okay"; > > Don't show status in examples. Sorry, copy/paste at fault. Thanks for the feedback. Andrew > > > + > > + ethphy0: ethernet-phy@0 { > > + compatible = "ethernet-phy-ieee802.3-c22"; > > + reg = <0>; > > + }; > > + }; > > -- > > 2.20.1 > > >