linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Witt <thomas@witt.link>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Vidya Sagar <vidyas@nvidia.com>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [Bug 216877] New: Regression in PCI powermanagement breaks resume after suspend
Date: Thu, 26 Jan 2023 20:24:23 +0100	[thread overview]
Message-ID: <0b3c035f-74be-ed64-8edb-c83106fd11ad@witt.link> (raw)
In-Reply-To: <fa187ea6-eaba-92cd-b2bc-a62d25501826@witt.link>

On 04/01/2023 16:37, Thomas Witt wrote:
> On 04/01/2023 16:02, Bjorn Helgaas wrote:
>> Thanks for testing it.  Maybe Vidya will have more ideas.  The patch
>> below (based on v6.2-rc1) would revert 5e85eba6f50d and 4ff116d0d5fd.
>> If 5e85eba6f50d is the culprit, it should fix the regression.  It
>> would also potentially break L1 substates after resume, so we'd like
>> to avoid reverting it if possible.
>>
>> But the "Unable to change power state from D3hot to D0, device
>> inaccessible" symptom suggests that the device is still in D3, which
>> would be more like a wakeup issue than an ASPM issue.
>>
>> Your bisect log said 3e347969a577 ("PCI/PM: Reduce D3hot delay with
>> usleep_range()") was "good", but it would be worth double-checking,
>> e.g., see if reverting it from v6.2-rc1 makes any difference.
>>
>> Bjorn
>>
>> commit 61de2691d549 ("Revert "PCI/ASPM: Refactor L1 PM Substates 
>> Control Register programming"")
>> parent 1b929c02afd3
>> Author: Bjorn Helgaas <bhelgaas@google.com>
>> Date:   Wed Jan 4 08:38:53 2023 -0600
>>
>>      Revert "PCI/ASPM: Refactor L1 PM Substates Control Register 
>> programming"
> 
> With this patch on top of 6.2-rc1 suspend/resume works and my PCI 
> devices come back online.
> 

Hello Bjorn, hello Vidya,

do you have an Idea what went wrong in that commit to cause my PCI 
devices to not return from D3?

BR
Thomas

  reply	other threads:[~2023-01-26 19:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-216877-41252@https.bugzilla.kernel.org/>
2023-01-02 17:15 ` [Bug 216877] New: Regression in PCI powermanagement breaks resume after suspend Bjorn Helgaas
2023-01-04  0:30   ` Bjorn Helgaas
2023-01-04  8:44     ` Thomas Witt
2023-01-04 15:02       ` Bjorn Helgaas
2023-01-04 15:37         ` Thomas Witt
2023-01-26 19:24           ` Thomas Witt [this message]
2023-02-02 20:49             ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b3c035f-74be-ed64-8edb-c83106fd11ad@witt.link \
    --to=thomas@witt.link \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).