From: Helge Deller <deller@gmx.de>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: kernel test robot <lkp@intel.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
linux-parisc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>,
Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH] serial: parisc: GSC: fix build when PCI_LBA is not set
Date: Sun, 13 Feb 2022 21:35:16 +0100 [thread overview]
Message-ID: <0baabcbc-196e-08fa-e2db-b7e925993cc1@gmx.de> (raw)
In-Reply-To: <20220213193903.8815-1-rdunlap@infradead.org>
Hi Randy,
On 2/13/22 20:39, Randy Dunlap wrote:
> There is a build error when using a kernel .config file from
> 'kernel test robot' for a different build problem:
>
> hppa64-linux-ld: drivers/tty/serial/8250/8250_gsc.o: in function `.LC3':
> (.data.rel.ro+0x18): undefined reference to `iosapic_serial_irq'
>
> when:
> CONFIG_GSC=y
> CONFIG_SERIO_GSCPS2=y
> CONFIG_SERIAL_8250_GSC=y
> CONFIG_PCI is not set
> and hence PCI_LBA is not set.
> IOSAPIC depends on PCI_LBA, so IOSAPIC is not set/enabled.
>
> Making SERIAL_8250_GSC depend on PCI_LBA prevents the build error.
It maybe makes the build error go away, but ...
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
> Cc: Helge Deller <deller@gmx.de>
> Cc: linux-parisc@vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-serial@vger.kernel.org
> Cc: Jiri Slaby <jirislaby@kernel.org>
> Cc: Johan Hovold <johan@kernel.org>
> ---
> drivers/tty/serial/8250/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20220211.orig/drivers/tty/serial/8250/Kconfig
> +++ linux-next-20220211/drivers/tty/serial/8250/Kconfig
> @@ -118,7 +118,7 @@ config SERIAL_8250_CONSOLE
>
> config SERIAL_8250_GSC
> tristate
> - depends on SERIAL_8250 && GSC
> + depends on SERIAL_8250 && GSC && PCI_LBA
> default SERIAL_8250
The serial device is on the GSC bus, so if you make it
dependend on the PCI bus it will not be useable on machines
which only have a GSC bus...
We need another patch.
Do you have a link to the build error?
Helge
next prev parent reply other threads:[~2022-02-13 20:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-13 19:39 [PATCH] serial: parisc: GSC: fix build when PCI_LBA is not set Randy Dunlap
2022-02-13 20:35 ` Helge Deller [this message]
2022-02-13 21:07 ` Randy Dunlap
2022-02-13 22:15 ` Helge Deller
2022-02-14 0:15 ` Randy Dunlap
2022-02-14 12:05 ` Helge Deller
2022-02-14 12:24 ` Helge Deller
2022-02-14 17:47 ` Randy Dunlap
2022-02-14 18:29 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0baabcbc-196e-08fa-e2db-b7e925993cc1@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).