From: Baolin Wang <baolin.wang@linaro.org>
To: balbi@kernel.org, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linaro-kernel@lists.linaro.org, broonie@kernel.org,
baolin.wang@linaro.org
Subject: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler
Date: Mon, 26 Dec 2016 16:01:10 +0800 [thread overview]
Message-ID: <0d79eb1f34e409749a136173b68f365b545c4789.1482738764.git.baolin.wang@linaro.org> (raw)
On some platfroms(like x86 platform), when one core is running the USB gadget
irq thread handler by dwc3_thread_interrupt(), meanwhile another core also can
respond other interrupts from dwc3 controller and modify the event buffer by
dwc3_interrupt() function, that will cause getting the wrong event count in
irq thread handler to make the USB function abnormal.
We should add spin_lock/unlock() in dwc3_check_event_buf() to avoid this race.
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
drivers/usb/dwc3/gadget.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 6785595..1a1e1f4 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -2894,10 +2894,13 @@ static irqreturn_t dwc3_check_event_buf(struct dwc3_event_buffer *evt)
return IRQ_HANDLED;
}
+ spin_lock(&dwc->lock);
count = dwc3_readl(dwc->regs, DWC3_GEVNTCOUNT(0));
count &= DWC3_GEVNTCOUNT_MASK;
- if (!count)
+ if (!count) {
+ spin_unlock(&dwc->lock);
return IRQ_NONE;
+ }
evt->count = count;
evt->flags |= DWC3_EVENT_PENDING;
@@ -2914,6 +2917,7 @@ static irqreturn_t dwc3_check_event_buf(struct dwc3_event_buffer *evt)
memcpy(evt->cache, evt->buf, count - amount);
dwc3_writel(dwc->regs, DWC3_GEVNTCOUNT(0), count);
+ spin_unlock(&dwc->lock);
return IRQ_WAKE_THREAD;
}
--
1.7.9.5
next reply other threads:[~2016-12-26 8:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-26 8:01 Baolin Wang [this message]
2016-12-27 2:39 ` [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler Lu Baolu
2016-12-27 2:58 ` Baolin Wang
2016-12-27 4:45 ` Lu Baolu
2016-12-27 11:05 ` Felipe Balbi
2016-12-28 15:27 ` Janusz Dziedzic
2016-12-28 16:19 ` Felipe Balbi
2016-12-29 1:29 ` John Youn
2017-01-05 19:08 ` John Youn
2017-01-06 2:44 ` Baolin Wang
2016-12-27 10:52 ` Janusz Dziedzic
2016-12-27 11:06 ` Baolin Wang
2016-12-27 11:11 ` Felipe Balbi
2016-12-27 12:16 ` Baolin Wang
2016-12-28 12:30 ` Janusz Dziedzic
2017-01-03 12:21 ` Baolin Wang
2017-01-03 12:33 ` Felipe Balbi
2017-01-05 2:07 ` Baolin Wang
2017-01-05 9:26 ` Felipe Balbi
2017-01-05 9:43 ` Baolin Wang
2017-01-05 11:19 ` Felipe Balbi
2017-01-05 12:03 ` Baolin Wang
2016-12-27 11:07 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d79eb1f34e409749a136173b68f365b545c4789.1482738764.git.baolin.wang@linaro.org \
--to=baolin.wang@linaro.org \
--cc=balbi@kernel.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).