linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Arvind Sankar <nivedita@alum.mit.edu>, Al Viro <viro@zeniv.linux.org.uk>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
	linux-kbuild@vger.kernel.org, Rob Landley <rob@landley.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] menuconfig: restore prompt dependencies in help text
Date: Thu, 2 Jan 2020 08:14:43 -0800	[thread overview]
Message-ID: <0ea3e528-4835-ff9c-f5a2-f711666ba75f@infradead.org> (raw)
In-Reply-To: <20200101222644.GA438328@rani.riverdale.lan>

On 1/1/20 2:26 PM, Arvind Sankar wrote:
> On Wed, Jan 01, 2020 at 09:04:26PM +0000, Al Viro wrote:
>> On Wed, Jan 01, 2020 at 03:41:52PM -0500, Arvind Sankar wrote:
>>> Commit bcdedcc1afd6 ("menuconfig: print more info for symbol without
>>> prompts") moved some code from get_prompt_str to get_symbol_str so that
>>> dependency information for symbols without prompts could be shown.
>>>
>>> This code would be better copied rather than moved, as the change had
>>> the side-effect of not showing any extra dependencies that the prompt
>>> might have over the symbol.
>>>
>>> Put back a copy of the dependency printing code in get_prompt_str.
>>
>> Umm... Is "visible" really accurate in this case?  AFAICS, the
>> entry (and help for it) _is_ visible with EXPERT=n.  OTOH, with
>> EXPERT=y and MULTIUSER=n it disappears completely.
>>
>> I'm not familiar with kconfig guts (and not too concerned about that
>> feature of help there, TBH), but it looks like what you are printing
>> there is some mix of dependencies ("visible when") and selectability...
> 
> Perhaps not the most accurate term. For NAMESPACES it has a submenu, so
> it can't disappear as long as its selected, even if it's not editable
> any more. A "leaf" level option like MULTIUSER, otoh, does disappear
> completely (even though it's still selected).
> 
> But there are also things like CONFIG_VT, which stays visible, even
> though its not a menu.. I think because there is a visible option that
> depends on it and immediately follows, which menuconfig shows by
> indenting. If the order of UNIX98_PTYS and VT_HW_CONSOLE_BINDING is
> flipped in drivers/tty/Kconfig, then VT disappears when EXPERT=n.
> 
> Dunno, maybe Editable would be a better word than Visible?

I would prefer Editable instead of Visible.

and the Subject should be more than menuconfig since the patch also
"fixes" nconfig, xconfig, and gconfig.


Tested-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.
-- 
~Randy


  reply	other threads:[~2020-01-02 16:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-31  0:30 Why is CONFIG_VT forced on? Rob Landley
2019-12-31  0:36 ` Randy Dunlap
2019-12-31  0:53   ` Rob Landley
2019-12-31  0:59     ` Randy Dunlap
2019-12-31  1:45       ` Rob Landley
2019-12-31  2:00         ` Randy Dunlap
2019-12-31  2:04         ` Rob Landley
2019-12-31  2:03           ` Randy Dunlap
2019-12-31  2:33             ` Theodore Y. Ts'o
2019-12-31  2:40           ` Al Viro
2019-12-31  2:52             ` Al Viro
2019-12-31  3:27               ` Rob Landley
2019-12-31  3:53                 ` Al Viro
2019-12-31  4:18                   ` Al Viro
2019-12-31  5:58                     ` Al Viro
2020-01-01 20:41                       ` [PATCH] menuconfig: restore prompt dependencies in help text Arvind Sankar
2020-01-01 21:04                         ` Al Viro
2020-01-01 22:26                           ` Arvind Sankar
2020-01-02 16:14                             ` Randy Dunlap [this message]
2020-01-02 23:14                               ` [PATCH] kconfig: " Arvind Sankar
2020-01-03  2:10                                 ` Masahiro Yamada
2020-01-03  4:20                                   ` Arvind Sankar
2019-12-31  1:55 ` Why is CONFIG_VT forced on? Theodore Y. Ts'o
2020-01-04 20:27   ` Enrico Weigelt, metux IT consult
2019-12-31  2:28 ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ea3e528-4835-ff9c-f5a2-f711666ba75f@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nivedita@alum.mit.edu \
    --cc=rob@landley.net \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).