From: David Lechner <david@lechnology.com>
To: Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] ARM: davinci: Don't append git rev to local version
Date: Wed, 26 Oct 2016 10:44:49 -0500 [thread overview]
Message-ID: <0fd82064-dd4a-8144-8b9d-88191407a4bc@lechnology.com> (raw)
In-Reply-To: <47ad8be9-54e0-4e0c-3ff5-31662e6ca4de@ti.com>
On 10/26/2016 05:54 AM, Sekhar Nori wrote:
> On Monday 24 October 2016 08:45 PM, David Lechner wrote:
>> On 10/24/2016 06:35 AM, Sekhar Nori wrote:
>>> On Saturday 22 October 2016 12:06 AM, David Lechner wrote:
>>>> In the davinci default configuration, don't append the git revision to
>>>> the local kernel version by. This seems like the more desirable default
>>>> value.
>>>
>>> Why? To the contrary I actually quite like the fact that the git commit
>>> is appended to version string. Makes it easy for me to cross-check that
>>> I am booting the right image.
>>>
>>>>
>>>> Signed-off-by: David Lechner <david@lechnology.com>
>>>
>>> Thanks,
>>> Sekhar
>>>
>>
>> Each time you make a commit, you get a new version, which installs
>> another copy of the kernel modules on the device. This will fill up the
>> SD card if you are making many commits.
>
> Right, but thats easily fixable by removing existing modules before
> installing new ones.
>
>> Also, if someone wants to build the mainline kernel using the default
>> configuration, it seems odd to have a git revision tacked on to the end
>> even though you made no revisions.
>
> If you checkout a tag and build, then no commit information is added.
> Which I guess is what most end users will do.
>
> I don't see this done in other defconfigs like omap2plus and multi_v7 as
> well. I would like to keep it similar for davinci.
>
> Thanks,
> Sekhar
>
OK, I will drop this patch.
next prev parent reply other threads:[~2016-10-26 15:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 18:36 [PATCH 0/5] Support for LEGO MINDSTORTMS EV3 David Lechner
2016-10-21 18:36 ` [PATCH 1/5] ARM: davinci: Compile MMC in kernel David Lechner
2016-10-26 11:33 ` Sekhar Nori
2016-10-21 18:36 ` [PATCH 2/5] ARM: davinci: Don't append git rev to local version David Lechner
2016-10-24 11:35 ` Sekhar Nori
2016-10-24 15:15 ` David Lechner
2016-10-26 10:54 ` Sekhar Nori
2016-10-26 15:44 ` David Lechner [this message]
2016-10-21 18:36 ` [PATCH 3/5] ARM: davinci: enable gpio poweroff in default config David Lechner
2016-10-26 11:09 ` Sekhar Nori
2016-10-21 18:36 ` [PATCH 4/5] ARM: davinci: enable LEDs default-on trigger " David Lechner
2016-10-27 11:29 ` Sekhar Nori
2016-10-27 15:49 ` David Lechner
2016-10-28 9:03 ` Sekhar Nori
2016-10-21 18:36 ` [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts David Lechner
2016-10-21 19:13 ` Kevin Hilman
2016-10-24 11:58 ` Sekhar Nori
2016-10-24 15:50 ` David Lechner
2016-10-24 19:50 ` David Lechner
2016-10-24 21:20 ` David Lechner
2016-10-25 10:58 ` Sekhar Nori
2016-10-25 15:44 ` David Lechner
2016-10-25 2:56 ` David Lechner
2016-10-27 1:30 ` David Lechner
2016-10-21 18:45 ` [PATCH 0/5] Support for LEGO MINDSTORTMS EV3 Lennart Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fd82064-dd4a-8144-8b9d-88191407a4bc@lechnology.com \
--to=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).