From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Jochen Friedrich <jochen@scram.de>, linux-kernel@vger.kernel.org
Subject: Re: 2.3.39 compile errors on Alpha
Date: 30 Sep 2002 13:35:40 +0100 [thread overview]
Message-ID: <1033389340.16337.14.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <Pine.NEB.4.44.0209301257210.12605-100000@mimas.fachschaften.tu-muenchen.de>
On Mon, 2002-09-30 at 12:08, Adrian Bunk wrote:
> this is a known issue, the following patch (already in Linus' BK tree)
> fixes it:
>
> --- linux-2.5.35-VIRGIN/drivers/atm/atmtcp.c 2002-08-24 00:08:21.000000000 -0700
> +++ linux-2.5.35/drivers/atm/atmtcp.c 2002-09-16 21:04:30.000000000 -0700
> @@ -275,7 +275,7 @@
> result = -ENOBUFS;
> goto done;
> }
> - new_skb->stamp = xtime;
> + do_gettimeofday(&new_skb->stamp);
Is this actually safe - suppose the machine has no tsc counter (eg old
x86 or indeed new x86 numa, speedstep using, etc). In that case
do_gettimeofday doesn't appear to be either IRQ safe or fast enough to
use in this way ?
Alan
next prev parent reply other threads:[~2002-09-30 12:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-30 7:46 2.3.39 compile errors on Alpha Jochen Friedrich
2002-09-30 7:59 ` Jochen Friedrich
2002-09-30 11:08 ` Adrian Bunk
2002-09-30 12:35 ` Alan Cox [this message]
2002-09-30 12:25 ` David S. Miller
2002-09-30 13:15 ` Alan Cox
2002-09-30 13:20 ` 2.5.39 XConfig Processor Detection Adam Voigt
2002-09-30 13:30 ` Dave Jones
2002-09-30 13:48 ` Adam Voigt
2002-09-30 20:39 ` 2.3.39 compile errors on Alpha David S. Miller
2002-09-30 17:58 ` 2.3.39 LLC on Alpha broken? Jochen Friedrich
2002-09-30 18:07 ` Arnaldo Carvalho de Melo
2002-09-30 8:04 ` Jochen Friedrich
2002-09-30 21:04 ` Jochen Friedrich
2002-10-01 14:46 ` Ivan Kokshaysky
2002-10-01 16:05 ` Falk Hueffner
2002-09-30 20:59 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1033389340.16337.14.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bunk@fs.tum.de \
--cc=jochen@scram.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).