From: James Bottomley <James.Bottomley@steeleye.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Mukker, Atul" <atulm@lsil.com>,
"'alan@redhat.com'" <alan@redhat.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>,
"'linux-megaraid-devel@dell.com'" <linux-megaraid-devel@dell.com>,
"'linux-megaraid-announce@dell.com'"
<linux-megaraid-announce@dell.com>
Subject: Re: [ANNOUNCE]: version 2.00.3 megaraid driver for 2.4.x and 2.5.67 kernels
Date: 17 Apr 2003 09:41:59 -0500 [thread overview]
Message-ID: <1050590521.2026.76.camel@mulgrave> (raw)
In-Reply-To: <20030417133820.A12503@infradead.org>
On Thu, 2003-04-17 at 07:38, Christoph Hellwig wrote:
> On Wed, Apr 16, 2003 at 04:34:22PM -0400, Mukker, Atul wrote:
> > New megaraid driver 2.00.3 is now available at
> > ftp://ftp.lsil.com/pub/linux-megaraid For this driver, a patch is also
> > available for 2.5.67 kernel.
[...]
I'm not inclined to force style changes in any drivers with active
maintainers on the grounds that we already have much worse offenders in
the tree (and style changes do make merging a pain).
I counted one serious issue:
The try_module_get problem
One future compatibility issue:
->detect moved to scsi_add_host (for the device model).
One issue that would improve the driver internally:
move hba_soft_state array to dynamic ->hostdata
plus a list of other more style related issues.
I'll fix up the first one, Atul, can you take the other two for a future
patch (the others Christoph mentions might be nice, too...)?
James
next prev parent reply other threads:[~2003-04-17 14:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-16 20:34 [ANNOUNCE]: version 2.00.3 megaraid driver for 2.4.x and 2.5.67 kernels Mukker, Atul
2003-04-17 12:38 ` Christoph Hellwig
2003-04-17 12:52 ` Alan Cox
2003-04-17 12:57 ` Christoph Hellwig
2003-04-17 13:23 ` Alan Cox
2003-04-17 13:56 ` Christoph Hellwig
2003-04-17 14:41 ` James Bottomley [this message]
2003-04-17 17:25 ` James Bottomley
2003-04-25 23:04 Mukker, Atul
2003-04-26 19:42 Mukker, Atul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1050590521.2026.76.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=alan@redhat.com \
--cc=atulm@lsil.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-megaraid-announce@dell.com \
--cc=linux-megaraid-devel@dell.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).