linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: john stultz <johnstul@us.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@digeo.com>
Subject: Re: tg3 - irq #: nobody cared!
Date: 06 May 2003 21:58:29 -0700	[thread overview]
Message-ID: <1052283509.9817.1.camel@rth.ninka.net> (raw)
In-Reply-To: <1052258580.4495.12.camel@w-jstultz2.beaverton.ibm.com>

On Tue, 2003-05-06 at 15:03, john stultz wrote:
> 	Not sure if this is the proper fix, but it stops the kernel from
> complaining. I saw Andrew suggest something similar for a sound driver.

Definitely not the right fix.  If the hardware status struct
indicates no event is pending, then we return 0 since we
didn't "handle" the interrupt.

Otherwise, whats the point of the irqreturn_t at all? :-)

-- 
David S. Miller <davem@redhat.com>

  reply	other threads:[~2003-05-07  4:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-06 22:03 tg3 - irq #: nobody cared! john stultz
2003-05-07  4:58 ` David S. Miller [this message]
2003-05-07  5:08   ` Andrew Morton
2003-05-07  4:03     ` David S. Miller
2003-05-07 11:57 Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1052283509.9817.1.camel@rth.ninka.net \
    --to=davem@redhat.com \
    --cc=akpm@digeo.com \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).