linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Christopher Wedgwood <cw@sgi.com>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
	Alan Cox <alan@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	wildos@sgi.com
Subject: Re: [PATCH] (2.4.22-pre6 BK) New (IDE) driver: SGI IOC4
Date: 17 Jul 2003 13:26:27 +0100	[thread overview]
Message-ID: <1058444787.8620.42.camel@dhcp22.swansea.linux.org.uk> (raw)
In-Reply-To: <20030715222744.GA7478@taniwha.engr.sgi.com>

Ok the big problem I'm having with this code is understanding why most
of it even exists. Is this chip subtly different in some way I am
missing and so unable to use the generic PCI stuff or is most of the
copied code simply not needed.

As far as I can see the only "weirdness" it has is that the base
registers are off a non standard BAR. Thats something we already support
in the core IDE PCI code (see the cs5520 Kahlua driver in 2.6.0test)

Work was also done recently to allow clean wrapping of the generic DMA
stuff for devices that had to do custom setup around each IDE DMA (eg
HPT372N).

Basically - in what was is your controller not the same as generic MWDMA
capable IDE ?


      parent reply	other threads:[~2003-07-17 12:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-15 22:27 [PATCH] (2.4.22-pre6 BK) New (IDE) driver: SGI IOC4 Christopher Wedgwood
2003-07-15 23:47 ` Jeff Garzik
2003-07-16  0:13   ` Alan Cox
2003-07-17 12:26 ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1058444787.8620.42.camel@dhcp22.swansea.linux.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=alan@redhat.com \
    --cc=cw@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=wildos@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).