From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: [PATCH] i2c driver changes 2.6.0-test1
Date: Sat, 19 Jul 2003 08:54:56 -0700 [thread overview]
Message-ID: <10586300964092@kroah.com> (raw)
In-Reply-To: <1058630094923@kroah.com>
ChangeSet 1.1527, 2003/07/18 23:32:43-07:00, greg@kroah.com
[PATCH] I2C: minor cleanups to the i2c-nforce2 driver.
drivers/i2c/busses/i2c-nforce2.c | 24 +++---------------------
1 files changed, 3 insertions(+), 21 deletions(-)
diff -Nru a/drivers/i2c/busses/i2c-nforce2.c b/drivers/i2c/busses/i2c-nforce2.c
--- a/drivers/i2c/busses/i2c-nforce2.c Sat Jul 19 08:48:02 2003
+++ b/drivers/i2c/busses/i2c-nforce2.c Sat Jul 19 08:48:02 2003
@@ -43,14 +43,10 @@
#include <linux/delay.h>
#include <asm/io.h>
-#ifdef MODULE_LICENSE
MODULE_LICENSE("GPL");
-#endif
MODULE_AUTHOR ("Hans-Frieder Vogt <hfvogt@arcor.de>");
MODULE_DESCRIPTION("nForce2 SMBus driver");
-#define LM_VERSION "2.80-lk1"
-#define LM_DATE "2003/07/12"
#ifndef PCI_DEVICE_ID_NVIDIA_NFORCE2_SMBUS
#define PCI_DEVICE_ID_NVIDIA_NFORCE2_SMBUS 0x0064
@@ -114,13 +110,6 @@
static s32 nforce2_access(struct i2c_adapter *adap, u16 addr,
unsigned short flags, char read_write,
u8 command, int size, union i2c_smbus_data *data);
-#if 0
-static void nforce2_do_pause(unsigned int amount);
-#endif
-/*
-static int nforce2_block_transaction(union i2c_smbus_data *data,
- char read_write, int i2c_enable);
- */
static u32 nforce2_func(struct i2c_adapter *adapter);
@@ -345,18 +334,12 @@
smbus->base, smbus->base+smbus->size-1, name);
return -1;
}
-
- /* TODO: find a better way to find out whether this file is compiled
- * with i2c 2.7.0 of earlier
- */
-/*#ifdef I2C_HW_SMBUS_AMD8111
+/*
smbus->adapter.owner = THIS_MODULE;
-#endif
-
smbus->adapter.id = I2C_ALGO_SMBUS | I2C_HW_SMBUS_NFORCE2;
smbus->adapter.algo = &smbus_algorithm;
- smbus->adapter.algo_data = smbus;*/
-
+ smbus->adapter.algo_data = smbus;
+*/
smbus->adapter = nforce2_adapter;
smbus->adapter.dev.parent = &dev->dev;
snprintf(smbus->adapter.dev.name, DEVICE_NAME_SIZE,
@@ -430,7 +413,6 @@
static int __init nforce2_init(void)
{
- printk(KERN_INFO "i2c-nforce2 version %s (%s)\n", LM_VERSION, LM_DATE);
return pci_module_init(&nforce2_driver);
}
next prev parent reply other threads:[~2003-07-19 15:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-19 15:52 [BK PATCH] i2c driver changes for 2.6.0-test1 Greg KH
2003-07-19 15:54 ` [PATCH] i2c driver changes 2.6.0-test1 Greg KH
2003-07-19 15:54 ` Greg KH
2003-07-19 15:54 ` Greg KH
2003-07-19 15:54 ` Greg KH
2003-07-19 15:54 ` Greg KH [this message]
2003-07-19 15:54 ` Greg KH
2003-07-23 17:43 ` Marcelo Penna Guerra
2003-07-24 13:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10586300964092@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).