From: Michael Straube <straube.linux@gmail.com>
To: Joe Perches <joe@perches.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: rtl8188eu: rename variable isCCKrate - style
Date: Sun, 21 Oct 2018 21:49:46 +0200 [thread overview]
Message-ID: <10d25629-f125-1e8d-9fd1-d4492b042a15@gmail.com> (raw)
In-Reply-To: <5f8063e4163361d64069d0fbecc7f723b503a4b8.camel@perches.com>
On 10/21/18 2:26 PM, Joe Perches wrote:
> It would be sensible to convert is_cck_rate from u8 to bool at the
> same
> time and remove the ternary ? true : false too.
>
> As well, perhaps remove its apparently unnecessary initialization.
>
>
I've added a patch and resent the series. Thank you.
Michael
prev parent reply other threads:[~2018-10-21 19:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-20 11:08 [PATCH 1/3] staging: rtl8188eu: simplify odm_evm_db_to_percentage() Michael Straube
2018-10-20 11:08 ` [PATCH 2/3] staging: rtl8188eu: rename variable Max_spatial_stream - style Michael Straube
2018-10-20 11:08 ` [PATCH 3/3] staging: rtl8188eu: rename variable isCCKrate " Michael Straube
2018-10-21 12:26 ` Joe Perches
2018-10-21 19:49 ` Michael Straube [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10d25629-f125-1e8d-9fd1-d4492b042a15@gmail.com \
--to=straube.linux@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).