From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Arjan van de Ven <arjan@infradead.org>
Cc: viro@zenII.uk.linux.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@osdl.org>
Subject: Re: make flock_lock_file_wait static
Date: Tue, 11 Jan 2005 14:16:44 -0500 [thread overview]
Message-ID: <1105471004.12005.46.camel@lade.trondhjem.org> (raw)
In-Reply-To: <1105432299.3917.11.camel@laptopd505.fenrus.org>
ty den 11.01.2005 Klokka 09:31 (+0100) skreiv Arjan van de Ven:
> On Mon, 2005-01-10 at 09:23 -0500, Trond Myklebust wrote:
> > må den 10.01.2005 Klokka 09:38 (+0100) skreiv Arjan van de Ven:
> > >
> > > > is "sooner or later" and "maybe someone else uses it" worth making
> > > > everyone elses kernel bigger by 500 bytes of code ?
> > >
> > > eh 60 not 500; sorry need coffee
> >
> > It's an API that provides *necessary* functionality for those
> > filesystems that wish to override the standard flock(). It was very
> > recently introduced by a third party, so we haven't had time to code up
> > an NFS flock yet.
>
> where "recently" is last september....
> bloating the kernel unused since then...
Feel free to help out if you think the NFS development effort is
understaffed.
> If it is going to take a LOT longer though I still feel it's wrong to
> bloat *everyones* kernel with this stuff.
>
> (you may think "it's only 100 bytes", well, there are 700+ other such
> functions, total that makes over at least 70Kb of unswappable, wasted
> memory if not more.)
A list of these 700+ unused exported APIs would be very useful so that
we can deprecate and/or get rid of them.
Concerning this case, though, and to make what I said in the earlier
mails (a lot) more explicit.
If you unexport flock_lock_file_wait(), then you might as well back out
the entire bloody ->flock() changeset instead because keeping the
->flock() VFS override support without the functionality to make
implementation practical (which is what you appear to want to do) is a
waste of more than 70 bytes of memory.
Now please go and figure out what it is you actually want to do here.
Trond
--
Trond Myklebust <trond.myklebust@fys.uio.no>
next prev parent reply other threads:[~2005-01-11 19:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-09 19:42 make flock_lock_file_wait static Arjan van de Ven
2005-01-09 22:44 ` Trond Myklebust
2005-01-10 8:19 ` Arjan van de Ven
2005-01-10 8:38 ` Arjan van de Ven
2005-01-10 14:23 ` Trond Myklebust
2005-01-11 8:31 ` Arjan van de Ven
2005-01-11 19:16 ` Trond Myklebust [this message]
2005-01-11 19:36 ` Arjan van de Ven
2005-01-25 18:58 ` Paul E. McKenney
2005-01-26 3:10 ` Andrew Morton
2005-01-26 9:01 ` Arjan van de Ven
2005-01-26 16:07 ` Paul E. McKenney
2005-01-26 18:59 ` Arjan van de Ven
2005-01-28 14:14 ` Paul E. McKenney
2005-01-28 18:50 ` Christoph Hellwig
2005-01-28 19:01 ` Arjan van de Ven
2005-01-26 9:43 ` Christoph Hellwig
2005-01-26 9:51 ` Al Viro
2005-01-26 9:55 ` Christoph Hellwig
2005-01-26 10:00 ` Al Viro
2005-01-15 21:35 ` Adrian Bunk
2005-01-15 22:07 ` Trond Myklebust
2005-01-10 8:35 ` Ken Preslan
2005-01-10 8:44 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1105471004.12005.46.camel@lade.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zenII.uk.linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).