From: David Woodhouse <dwmw2@infradead.org>
To: Olaf Hering <olh@suse.de>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
hpa@zytor.com, torvalds@osdl.org
Subject: Re: [PATCH] raid6: altivec support
Date: Mon, 17 Jan 2005 10:16:32 +0000 [thread overview]
Message-ID: <1105956993.26551.327.camel@hades.cambridge.redhat.com> (raw)
In-Reply-To: <20050109151353.GA9508@suse.de>
On Sun, 2005-01-09 at 16:13 +0100, Olaf Hering wrote:
>
> > ChangeSet 1.2347, 2005/01/08 14:02:27-08:00, hpa@zytor.com
> >
> > [PATCH] raid6: altivec support
> >
> > This patch adds Altivec support for RAID-6, if appropriately configured on
> > the ppc or ppc64 architectures. Note that it changes the compile flags for
> > ppc64 in order to handle -maltivec correctly; this change was vetted on the
> > ppc64 mailing list and OK'd by paulus.
>
> This fails to compile on ppc, enable_kernel_altivec() is an exported but
> undeclared function. cpu_features is also missing.
>
> drivers/md/raid6altivec1.c: In function `raid6_altivec1_gen_syndrome':
> drivers/md/raid6altivec1.c:99: warning: implicit declaration of function `enable_kernel_altivec'
> drivers/md/raid6altivec1.c: In function `raid6_have_altivec':
> drivers/md/raid6altivec1.c:111: error: request for member `cpu_features' in something not a structure or union
> drivers/md/raid6altivec2.c: In function `raid6_altivec2_gen_syndrome':
> drivers/md/raid6altivec2.c:110: warning: implicit declaration of function `enable_kernel_altivec'
This makes it compile on PPC, but highlights the difference between
'cur_cpu_spec' on ppc32 and ppc64. Why is 'cur_cpu_spec' an array on
ppc32? Isn't 'cur' supposed to imply 'current'?
===== drivers/md/raid6altivec.uc 1.1 vs edited =====
--- 1.1/drivers/md/raid6altivec.uc Sat Jan 8 05:44:07 2005
+++ edited/drivers/md/raid6altivec.uc Mon Jan 17 09:45:20 2005
@@ -108,7 +108,11 @@
int raid6_have_altivec(void)
{
/* This assumes either all CPUs have Altivec or none does */
+#ifdef CONFIG_PPC64
return cur_cpu_spec->cpu_features & CPU_FTR_ALTIVEC;
+#else
+ return cur_cpu_spec[0]->cpu_features & CPU_FTR_ALTIVEC;
+#endif
}
#endif
--
dwmw2
next prev parent reply other threads:[~2005-01-17 10:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200501082324.j08NOIva030415@hera.kernel.org>
2005-01-09 15:13 ` [PATCH] raid6: altivec support Olaf Hering
2005-01-17 10:16 ` David Woodhouse [this message]
2005-01-17 14:58 ` Kumar Gala
2005-01-19 4:11 ` Benjamin Herrenschmidt
2005-01-19 7:43 ` David Woodhouse
2005-01-19 9:41 ` Paul Mackerras
2005-01-20 17:55 ` Tom Rini
2005-01-19 14:45 ` Kumar Gala
2005-01-19 14:48 ` David Woodhouse
2005-01-19 14:54 ` Kumar Gala
2005-01-19 15:08 ` Geert Uytterhoeven
2005-01-19 15:15 ` Kumar Gala
2005-01-19 15:27 ` Geert Uytterhoeven
2005-01-19 23:25 ` Benjamin Herrenschmidt
2005-01-20 7:40 ` [Lists-linux-kernel-news] " Jon Masters
2005-01-19 18:07 ` Jon Masters
2005-01-19 23:22 ` Benjamin Herrenschmidt
2005-01-23 11:17 ` Sven Luther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1105956993.26551.327.camel@hades.cambridge.redhat.com \
--to=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olh@suse.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).