From: Joe Perches <joe@perches.com>
To: Jakub Kicinski <kuba@kernel.org>, Leon Romanovsky <leon@kernel.org>
Cc: Vasyl Gomonovych <gomonovych@gmail.com>,
tariqt@nvidia.com, "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net/mlx4: Use true,false for bool variable
Date: Mon, 14 Dec 2020 11:15:01 -0800 [thread overview]
Message-ID: <1113d2d634d46adb9384e09c3f70cb8376a815c4.camel@perches.com> (raw)
In-Reply-To: <20201214110351.29ae7abb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Mon, 2020-12-14 at 11:03 -0800, Jakub Kicinski wrote:
> On Mon, 14 Dec 2020 13:16:08 +0200 Leon Romanovsky wrote:
> > On Mon, Dec 14, 2020 at 11:30:08AM +0100, Vasyl Gomonovych wrote:
> > > It is fix for semantic patch warning available in
> > > scripts/coccinelle/misc/boolinit.cocci
> > > Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable
> > > Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variable
> > >
> > > Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> > > ---
> > > - Add coccicheck script name
> > > - Simplify if condition
> > > ---
> > > drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +-
> > > drivers/net/ethernet/mellanox/mlx4/main.c | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > Please refrain from sending new version of patches as reply-to to
> > previous variants. It makes to appear previous patches out-of-order
> > while viewing in threaded mode.
>
> Yes, please! I'm glad I'm not the only one who feels this way! :)
I'm the other way.
I prefer revisions to single patches (as opposed to large patch series)
in the same thread.
There is no other easy way for changes to a patch to be tracked AFAIK.
Most email clients use both In-Reply-To: and References: headers as
the mechanism to thread replies.
Keeping the latest messages at the bottom of a thread works well
to see revision sequences.
next prev parent reply other threads:[~2020-12-14 19:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 10:05 [PATCH] net/mlx4: Use true,false for bool variable Vasyl Gomonovych
2020-12-12 5:25 ` Joe Perches
2020-12-12 17:02 ` Jakub Kicinski
2020-12-14 10:30 ` [PATCH v2] " Vasyl Gomonovych
2020-12-14 11:16 ` Leon Romanovsky
2020-12-14 19:03 ` Jakub Kicinski
2020-12-14 19:15 ` Joe Perches [this message]
2020-12-15 5:18 ` Leon Romanovsky
2020-12-15 5:37 ` Joe Perches
2020-12-15 6:18 ` Leon Romanovsky
2020-12-15 12:27 ` Vasyl
2020-12-14 23:58 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1113d2d634d46adb9384e09c3f70cb8376a815c4.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=gomonovych@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).