From: John Garry <john.garry@huawei.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
<gregkh@linuxfoundation.org>, <rafael@kernel.org>,
<martin.petersen@oracle.com>, <jejb@linux.ibm.com>,
<linuxarm@huawei.com>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] genirq/affinity: Add irq_update_affinity_desc()
Date: Fri, 27 Nov 2020 12:45:05 +0000 [thread overview]
Message-ID: <113d72e1-a624-5da9-89cf-eee950e5c984@huawei.com> (raw)
In-Reply-To: <34953f2d7b61f37ab1333627dc256975@kernel.org>
On 27/11/2020 09:57, Marc Zyngier wrote:
>> If I understand the code correctly, MSI_ALLOC_FLAGS_SHARED_DEVICE is
>> supposed to be set in info->flags in platform_msi_set_desc(), but this
>> is called per-msi after its_msi_prepare(), so we don't the flags set
>> at the right time. That's how it looks to me...
>
> Meh. I was trying multiple things, and of course commited the worse
> possible approach.
>
> I've updated the branch, having verified that we do get the flag in
> the ITS now.
Hi Marc,
That looks to work.
So do you have an upstream plan for this? I ask, as if you go with this,
then I may change my series to map and unmap all the irqs again - but
not sure about that.
Thanks,
John
next prev parent reply other threads:[~2020-11-27 12:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 12:33 [PATCH v2 0/3] Support managed interrupts for platform devices John Garry
2020-10-28 12:33 ` [PATCH v2 1/3] genirq/affinity: Add irq_update_affinity_desc() John Garry
2020-10-28 18:22 ` Thomas Gleixner
2020-11-02 17:32 ` John Garry
2020-11-02 20:35 ` Thomas Gleixner
2020-11-17 21:28 ` Thomas Gleixner
2020-11-18 11:34 ` John Garry
2020-11-18 20:38 ` Thomas Gleixner
2020-11-19 9:31 ` John Garry
2020-11-19 18:09 ` Thomas Gleixner
2020-11-19 19:56 ` John Garry
2020-11-19 21:03 ` Thomas Gleixner
2020-11-20 11:52 ` John Garry
2020-11-22 13:38 ` Marc Zyngier
2020-11-23 12:54 ` John Garry
2020-11-23 13:26 ` Marc Zyngier
2020-11-23 15:45 ` John Garry
2020-11-24 16:51 ` Marc Zyngier
2020-11-24 17:38 ` John Garry
2020-11-25 18:35 ` Marc Zyngier
2020-11-26 10:47 ` John Garry
2020-11-26 11:08 ` Marc Zyngier
2020-11-26 11:29 ` John Garry
2020-11-26 16:52 ` John Garry
2020-11-27 9:57 ` Marc Zyngier
2020-11-27 12:45 ` John Garry [this message]
2020-11-27 12:49 ` Marc Zyngier
2020-10-28 12:33 ` [PATCH v2 2/3] Driver core: platform: Add platform_get_irqs_affinity() John Garry
2020-10-28 12:33 ` [PATCH v2 3/3] scsi: hisi_sas: Expose HW queues for v2 hw John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=113d72e1-a624-5da9-89cf-eee950e5c984@huawei.com \
--to=john.garry@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=maz@kernel.org \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).