From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Shane <gnome42@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
"J. Bruce Fields" <bfields@fieldses.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: 2.6.24-rc3-git4 NFS crossmnt regression
Date: Fri, 07 Dec 2007 13:46:19 -0500 [thread overview]
Message-ID: <1197053179.7532.23.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <fa4052ef0712071014l524951e2we4705d84c5005cf3@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]
On Fri, 2007-12-07 at 13:14 -0500, Shane wrote:
> On Dec 7, 2007 7:02 AM, Andrew Morton <akpm@linux-foundation.org> wrote:
> ...
> > > 2.6.24-rc3-git1 is last known good kernel. The problem also exists
> > > with the latest snap 2.6.24-rc4-git4. NFS server is 2.6.23-rc9 and
> > > is unchanged.
> >
> > hm, there have been no nfs changes since 2.6.24-rc4.
>
> Ok, but the problem seems to have appeared before 2.6.24-rc4.
>
> > > It is easily reproducible here, hopefully for the person who
> > > knows how to debug it too :)
> > >
> >
> > I guess a full set of the commands which you typed to reproduce this would
> > help.
>
> Server is 2.6.23-rc9 and is exporting:
>
> /dirA/dirB
> 10.10.20.0/255.255.255.0(rw,async,no_root_squash,no_subtree_check,insecure,crossmnt)
> /dirA/dirB/dirC
> 10.10.20.0/255.255.255.0(rw,async,no_root_squash,no_subtree_check,insecure)
> /dirA/dirB/dirD
> 10.10.20.0/255.255.255.0(rw,async,no_root_squash,no_subtree_check,insecure)
>
> The NFS client (Core2 SMP) 2.6.24-rc3-git4:
>
> NFS-server:/dirA/dirB /dirA/dirB nfs
> auto,rsize=16384,wsize=16384,hard,intr,users,exec,nfsvers=3,tcp,nolock,actimeo=0
>
> Then on the client when the new kernel has booted:
>
> ls /dirA/dirB --> normal listing
> ls /dirA/dirB/dirC --> Stale NFS file handle
> ls /dirA/dirB/dirD --> Stale NFS file handle
>
> I will do a few more builds/boots and check -rc3-git2 and -rc3-git3.
This problem has already been reported. The fix (which I'm planning on
sending to Linus soon) is appended.
Cheers
Trond
[-- Attachment #2: linux-2.6.24-001-fix_submounts.dif --]
[-- Type: message/rfc822, Size: 997 bytes --]
From: Trond Myklebust <Trond.Myklebust@netapp.com>
Subject: NFS: Fix NFS mountpoint crossing...
Date:
Message-ID: <1197053179.7532.24.camel@heimdal.trondhjem.org>
The check that was added to nfs_xdev_get_sb() to work around broken
servers, works fine for NFSv2, but causes mountpoint crossing on NFSv3 to
always return ESTALE.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
---
fs/nfs/super.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index 2426e71..ea92920 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -1475,7 +1475,7 @@ static int nfs_xdev_get_sb(struct file_system_type *fs_type, int flags,
error = PTR_ERR(mntroot);
goto error_splat_super;
}
- if (mntroot->d_inode->i_op != &nfs_dir_inode_operations) {
+ if (mntroot->d_inode->i_op != server->nfs_client->rpc_ops->dir_inode_ops) {
dput(mntroot);
error = -ESTALE;
goto error_splat_super;
next prev parent reply other threads:[~2007-12-07 18:46 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-07 4:45 2.6.24-rc3-git4 NFS crossmnt regression Shane
2007-12-07 12:02 ` Andrew Morton
2007-12-07 18:14 ` Shane
2007-12-07 18:36 ` Shane
2007-12-07 18:46 ` Trond Myklebust [this message]
2007-12-07 18:55 ` Shane
2007-12-07 19:16 ` Shane
2007-12-07 19:39 ` Shane
2007-12-07 22:51 ` Trond Myklebust
2007-12-07 23:14 ` Andrew Morton
2007-12-07 23:35 ` Eric W. Biederman
2007-12-07 23:43 ` Rafael J. Wysocki
2007-12-08 0:00 ` Alexey Dobriyan
2007-12-08 0:15 ` Andrew Morton
2007-12-08 2:13 ` Shane
2007-12-08 4:18 ` Eric W. Biederman
2007-12-08 4:25 ` [PATCH 2.6.24-rc4] proc: Remove/Fix proc generic d_revalidate Eric W. Biederman
2007-12-08 17:15 ` Shane
2007-12-10 2:52 ` Petr Vandrovec
2007-12-10 13:32 ` Denis V. Lunev
2007-12-10 19:35 ` Andrew Morton
2007-12-10 21:35 ` vandrove
2007-12-08 4:39 ` 2.6.24-rc3-git4 NFS crossmnt regression Eric W. Biederman
2007-12-09 0:20 ` Maxim Levitsky
2007-12-09 19:50 ` J. Bruce Fields
2007-12-10 5:03 ` Neil Brown
2007-12-10 14:19 ` Maxim Levitsky
2007-12-10 14:36 ` J. Bruce Fields
2007-12-10 15:05 ` Maxim Levitsky
2007-12-10 15:47 ` J. Bruce Fields
2007-12-10 18:22 ` Maxim Levitsky
2007-12-10 21:03 ` Andrew Morton
2007-12-12 2:01 ` 2.6.24-rc3-git4 NFS crossmnt regression [SOLVED] Maxim Levitsky
2007-12-12 2:15 ` Andrew Morton
2007-12-12 2:19 ` Trond Myklebust
2007-12-12 2:44 ` Andrew Morton
2007-12-12 2:24 ` Maxim Levitsky
2007-12-10 19:51 ` 2.6.24-rc3-git4 NFS crossmnt regression Shane
2007-12-07 22:33 ` Andrew Morton
2007-12-07 22:39 ` Trond Myklebust
2007-12-07 19:54 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197053179.7532.23.camel@heimdal.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=gnome42@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).