From: Miquel van Smoorenburg <miquels@cistron.nl>
To: Anders Henke <anders.henke@1und1.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
matthew@wil.cx, FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: Re: broken dpt_i2o in 2.6.23 (was: ext2 check page: bad entry in directory) (fwd)
Date: Wed, 12 Dec 2007 14:07:59 +0100 [thread overview]
Message-ID: <1197464879.20796.15.camel@n2o.xs4all.nl> (raw)
In-Reply-To: <20071212033808.6fb92139.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]
On Wed, 2007-12-12 at 03:38 -0800, Andrew Morton wrote:
> On Wed, 12 Dec 2007 11:58:41 +0100 Anders Henke <anders.henke@1und1.de> wrote:
>
> > Hi,
> >
> > I'd like to let you now that my boxes are running a 32-bit kernel, so
> > the 64-bit-uncleanliness shouldn't apply to my boxes; however,
> >
> > http://www.miquels.cistron.nl/linux/dpt_i2o-64bit-2.6.23.patch
> >
> > fixed the issue on my testbox.
> >
> > I took a clean 2.6.23, applied patch, recompiled the kernel, reboot: works.
>
> What a huge patch :(
>
> We already reverted the offening patch so I assume that 2.6.24-rc5 is
> working for you?
>
> I guess we need to look at restoring "dpt_i2o: convert to SCSI hotplug
> model" and then absorbing what Miquel has done there.
This was just a patch I had lying around, if it worked it would confirm
my suspicion, which it has.
The minimal patch which is suitable for 2.6.23-stable and 2.6.24 would
be the attached one-liner. The "dpt_i2o: convert to SCSI hotplug model"
patch could be restored then.
(if the list eats the attachment, it's also available here:
http://www.miquels.cistron.nl/linux/linux-2.6.23+24-dpt_i2o-dma64.patch
)
Anders, does this one-liner patch work for you ?
Mike.
[-- Attachment #2: linux-2.6.23+24-dpt_i2o-dma64.patch --]
[-- Type: text/x-patch, Size: 511 bytes --]
diff -ruN linux-2.6.23.9.orig/drivers/scsi/dpt_i2o.c linux-2.6.23.9/drivers/scsi/dpt_i2o.c
--- linux-2.6.23.9.orig/drivers/scsi/dpt_i2o.c 2007-11-26 18:51:43.000000000 +0100
+++ linux-2.6.23.9/drivers/scsi/dpt_i2o.c 2007-12-12 13:21:05.000000000 +0100
@@ -905,8 +905,7 @@
}
pci_set_master(pDev);
- if (pci_set_dma_mask(pDev, DMA_64BIT_MASK) &&
- pci_set_dma_mask(pDev, DMA_32BIT_MASK))
+ if (pci_set_dma_mask(pDev, DMA_32BIT_MASK))
return -EINVAL;
base_addr0_phys = pci_resource_start(pDev,0);
next prev parent reply other threads:[~2007-12-12 13:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 10:58 broken dpt_i2o in 2.6.23 (was: ext2 check page: bad entry in directory) (fwd) Anders Henke
2007-12-12 11:38 ` Andrew Morton
2007-12-12 13:07 ` Miquel van Smoorenburg [this message]
2007-12-12 13:43 ` Anders Henke
2007-12-12 19:16 ` Andrew Morton
2007-12-12 19:54 ` James Bottomley
2007-12-12 22:16 ` [stable] " Greg KH
2007-12-13 10:11 ` [PATCH] dpt_i2o: don't set DMA_64BIT_MASK [was: Re: [stable] broken dpt_i2o in 2.6.23 (was: ext2 check page: bad entry in directory) (fwd)] Miquel van Smoorenburg
2007-12-13 12:58 ` James Bottomley
2007-12-12 14:17 ` broken dpt_i2o in 2.6.23 (was: ext2 check page: bad entry in directory) (fwd) Anders Henke
-- strict thread matches above, loose matches on Subject: below --
2007-11-29 13:03 broken dpt_i2o in 2.6.23 (was: ext2_check_page: " Jan Kara
2007-11-29 14:55 ` FUJITA Tomonori
2007-11-29 16:45 ` Anders Henke
2007-11-29 17:04 ` Matthew Wilcox
2007-11-30 13:27 ` Anders Henke
2007-11-29 17:09 ` FUJITA Tomonori
2007-11-30 10:34 ` Anders Henke
2007-12-11 14:40 ` Miquel van Smoorenburg
2007-12-11 21:53 ` Miquel van Smoorenburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197464879.20796.15.camel@n2o.xs4all.nl \
--to=miquels@cistron.nl \
--cc=akpm@linux-foundation.org \
--cc=anders.henke@1und1.de \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).