From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: hooanon05g@gmail.com
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org
Subject: Re: PATCH: Re: LOCKDEP customizable numbers upper limit
Date: Sat, 15 May 2021 07:41:02 +0900 [thread overview]
Message-ID: <11faf952-c0f8-6e1d-3560-12d77847a8ac@i-love.sakura.ne.jp> (raw)
In-Reply-To: <19935.1621016564@jrobl>
On 2021/05/15 3:22, hooanon05g@gmail.com wrote:
> Tetsuo Handa:
>> Please submit a patch that avoids only BUILD_BUG_ON().
>
> Here it is.
Thank you. In practice, nobody will increase by more than 5 bits.
Acked-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
>
> J. R. Okajima
>
> ----------------------------------------
> commit 43e103e1a5975c61334811d16e207e6d0ac57b77
> Author: J. R. Okajima <hooanon05g@gmail.com>
> Date: Sat May 15 03:17:10 2021 +0900
>
> LOCKDEP: upper limit LOCKDEP_CHAINS_BITS
>
> CONFIG_LOCKDEP_CHAINS_BITS value decides the size of chain_hlocks[] in
> kernel/locking/lockdep.c, and it is checked by add_chain_cache() with
> BUILD_BUG_ON((1UL << 24) <= ARRAY_SIZE(chain_hlocks));
> This patch is just to silence BUILD_BUG_ON().
>
> See-also: https://marc.info/?l=linux-kernel&m=162091320503900&w=2
> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: J. R. Okajima <hooanon05g@gmail.com>
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 678c13967580e..999ed5aa6bcee 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1390,7 +1390,7 @@ config LOCKDEP_BITS
> config LOCKDEP_CHAINS_BITS
> int "Bitsize for MAX_LOCKDEP_CHAINS"
> depends on LOCKDEP && !LOCKDEP_SMALL
> - range 10 30
> + range 10 21
> default 16
> help
> Try increasing this value if you hit "BUG: MAX_LOCKDEP_CHAINS too low!" message.
>
prev parent reply other threads:[~2021-05-14 22:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 13:39 LOCKDEP customizable numbers upper limit J. R. Okajima
2021-05-13 14:27 ` Tetsuo Handa
2021-05-14 18:22 ` PATCH: " hooanon05g
2021-05-14 22:41 ` Tetsuo Handa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11faf952-c0f8-6e1d-3560-12d77847a8ac@i-love.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=hooanon05g@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).