From: Ed Swierk <eswierk@aristanetworks.com>
To: Ingo Molnar <mingo@elte.hu>,
yinghai@kernel.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, linux-kernel@vger.kernel.org, lenb@kernel.org,
linux-acpi@vger.kernel.org, jbarnes@virtuousgeek.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] Detect mmconfig on nVidia MCP55
Date: Mon, 09 Feb 2009 11:26:39 -0800 [thread overview]
Message-ID: <1234207599.16237.6.camel@localhost.localdomain> (raw)
In-Reply-To: <20090204170440.GA31973@elte.hu>
Detect and enable memory-mapped PCI configuration space on the nVidia
MCP55 southbridge. Tested against 2.6.27.4 on an Arista Networks
development board with one MCP55, Coreboot firmware, no ACPI.
Signed-off-by: Ed Swierk <eswierk@aristanetworks.com>
---
I've tried to incorporate the code style feedback from Ingo. I'm not
sure whether this correctly handles boards with more than one MCP55, or
with an AMD 10h--Yinghai?
Index: linux-2.6.27.4/arch/x86/pci/mmconfig-shared.c
===================================================================
--- linux-2.6.27.4.orig/arch/x86/pci/mmconfig-shared.c
+++ linux-2.6.27.4/arch/x86/pci/mmconfig-shared.c
@@ -166,6 +166,36 @@ static const char __init *pci_mmcfg_amd_
return "AMD Family 10h NB";
}
+static const char __init *pci_mmcfg_nvidia_mcp55(void)
+{
+ u32 extcfg;
+ u64 base;
+ int end;
+ static const u32 extcfg_regnum = 0x90;
+ static const u32 extcfg_regsize = 4;
+ static const u32 extcfg_enable_mask = 0x80000000;
+ static const u32 extcfg_end_mask = 0x30000000;
+ static const int extcfg_end_shift = 28;
+ static const int extcfg_endbus[] = { 255, 127, 63, 31 };
+ static const u32 extcfg_base_mask = 0x00007fff;
+ static const int extcfg_base_lshift = 25;
+
+ raw_pci_ops->read(0, 0, PCI_DEVFN(0, 0), extcfg_regnum, extcfg_regsize,
+ &extcfg);
+
+ if (!(extcfg & extcfg_enable_mask))
+ return NULL;
+
+ if (extend_mmcfg(1) == -1)
+ return NULL;
+
+ base = (extcfg & extcfg_base_mask) << extcfg_base_lshift;
+ end = (extcfg & extcfg_end_mask) >> extcfg_end_shift;
+ fill_one_mmcfg(base, 0, 0, extcfg_endbus[end]);
+
+ return "nVidia MCP55";
+}
+
struct pci_mmcfg_hostbridge_probe {
u32 bus;
u32 devfn;
@@ -183,6 +213,8 @@ static struct pci_mmcfg_hostbridge_probe
0x1200, pci_mmcfg_amd_fam10h },
{ 0xff, PCI_DEVFN(0, 0), PCI_VENDOR_ID_AMD,
0x1200, pci_mmcfg_amd_fam10h },
+ { 0, PCI_DEVFN(0, 0), PCI_VENDOR_ID_NVIDIA,
+ 0x0369, pci_mmcfg_nvidia_mcp55 },
};
static int __init pci_mmcfg_check_hostbridge(void)
next prev parent reply other threads:[~2009-02-09 19:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 16:39 [PATCH] Detect mmconfig on nVidia MCP55 Ed Swierk
2009-02-04 17:04 ` Ingo Molnar
2009-02-05 17:05 ` Tvrtko Ursulin
2009-02-05 18:00 ` Ingo Molnar
2009-02-06 11:30 ` Tvrtko Ursulin
2009-02-06 15:42 ` Ingo Molnar
2009-02-06 16:10 ` Tvrtko Ursulin
2009-02-09 19:26 ` Ed Swierk [this message]
2009-02-09 19:42 ` Yinghai Lu
2009-02-04 17:07 ` Loic Prylli
2009-02-04 17:37 ` Ed Swierk
2009-02-04 20:00 ` Yinghai Lu
2009-02-04 20:12 ` Yinghai Lu
2009-02-04 21:25 ` Ingo Molnar
2009-02-04 23:10 ` Yinghai Lu
2009-02-10 1:59 ` [PATCH] x86/pci: host mmconfig detect clean up v3 Yinghai Lu
2009-02-10 2:00 ` Subject: [PATCH] x86/pci: Detect mmconfig on nVidia MCP55 -v2 Yinghai Lu
2009-02-10 22:57 ` Ed Swierk
2009-02-11 5:05 ` Yinghai Lu
2009-02-11 22:00 ` Ed Swierk
2009-02-12 5:03 ` Ed Swierk
2009-02-12 5:02 ` [PATCH] x86/pci: host mmconfig detect clean up v3 Ed Swierk
2009-02-05 2:24 ` [PATCH] x86/pci: host mmconfig detect clean up v2 Yinghai Lu
2009-02-05 18:15 ` Ingo Molnar
2009-02-05 18:31 ` Yinghai Lu
2009-02-05 22:04 ` Ed Swierk
2009-02-05 22:36 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234207599.16237.6.camel@localhost.localdomain \
--to=eswierk@aristanetworks.com \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).