From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Kiran Patil <kiran.patil@intel.com>,
Christoph Hellwig <hch@lst.de>, Yi Zou <yi.zou@intel.com>,
Joe Eykholt <joe.eykholt@gmail.com>
Subject: Re: linux-next: build warning after merge of the scsi tree
Date: Wed, 18 May 2011 19:54:48 -0700 [thread overview]
Message-ID: <1305773688.2856.449.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20110518135823.a809f829.sfr@canb.auug.org.au>
On Wed, 2011-05-18 at 13:58 +1000, Stephen Rothwell wrote:
> Hi Nicholas,
>
> On Tue, 17 May 2011 19:06:02 -0700 "Nicholas A. Bellinger" <nab@linux-iscsi.org> wrote:
> >
> > On Wed, 2011-05-18 at 11:49 +1000, Stephen Rothwell wrote:
> > >
> > > After merging the scsi tree, today's linux-next build (x86_64 allmodconfig)
> > > produced this warning:
> > >
> > > drivers/target/tcm_fc/tfc_io.c: In function 'ft_queue_data_in':
> > > drivers/target/tcm_fc/tfc_io.c:209: warning: format '%x' expects type 'unsigned int', but argument 5 has type 'size_t'
> > >
> > > Introduced by commit 3699d92a4d7b ("[SCSI] tcm_fc: Adding FC_FC4 provider
> > > (tcm_fc) for FCoE target (TCM - target core) support").
> > >
> >
> > It appears that this warning was fixed in LIO upstream a while back, but
> > did not make it into this morning scsi-misc merge. Please apply.
> >
> > >From b830de5068d0c3745e83393f81d87f745ef7a4f2 Mon Sep 17 00:00:00 2001
> > From: Nicholas Bellinger <nab@linux-iscsi.org>
> > Date: Thu, 17 Feb 2011 21:56:16 +0000
> > Subject: [PATCH] tcm_fc: Fix conversion spec compile warning in ft_queue_data_in
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset=UTF-8
> > Content-Transfer-Encoding: 8bit
> >
> > This patch fixes the following compile warning in ft_queue_data_in():
> >
> > drivers/target/tcm_fc/tfc_io.c: In function ‘ft_queue_data_in’:
> > drivers/target/tcm_fc/tfc_io.c:209: warning: format ‘%x’ expects type ‘unsigned int’, but argument 5 has type ‘size_t’
> >
> > Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
> > ---
> > drivers/target/tcm_fc/tfc_io.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/target/tcm_fc/tfc_io.c b/drivers/target/tcm_fc/tfc_io.c
> > index 4c3c0ef..3936bb1 100644
> > --- a/drivers/target/tcm_fc/tfc_io.c
> > +++ b/drivers/target/tcm_fc/tfc_io.c
> > @@ -206,7 +206,8 @@ int ft_queue_data_in(struct se_cmd *se_cmd)
> > "xid <0x%x>, remaining <0x%x>, "
> > "lso_max <0x%x>\n",
> > __func__, fp, ep->xid,
> > - remaining, lport->lso_max);
> > + (unsigned int)remaining,
> > + lport->lso_max);
>
> Given that "remaining" really is a length, surely it makes more sense to
> print it with %zd than to cast it and print it with %x ...
>
This is fine with me. Bad habit of explictly casting conversion
specifications from sector_t type usage..
Kiran, would you mind fixing this to use %zd in your tree, and include
this along with the TMR LUN_RESET bugfix for James to include in
scsi-misc..?
Thanks,
--nab
next prev parent reply other threads:[~2011-05-19 3:03 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110518114912.dfdf8835.sfr@canb.auug.org.au>
2011-05-18 2:06 ` linux-next: build warning after merge of the scsi tree Nicholas A. Bellinger
2011-05-18 3:58 ` Stephen Rothwell
2011-05-19 2:54 ` Nicholas A. Bellinger [this message]
2011-05-19 16:18 ` Kiran Patil
2011-05-19 16:22 ` Geert Uytterhoeven
2011-06-23 17:02 ` Randy Dunlap
2021-08-20 6:14 Stephen Rothwell
2021-08-20 6:30 ` Masahiro Yamada
-- strict thread matches above, loose matches on Subject: below --
2021-03-18 5:54 Stephen Rothwell
[not found] <CGME20200625034139epcas5p126a29921cc3f751528786b00f4b2828b@epcas5p1.samsung.com>
2020-06-25 3:41 ` Stephen Rothwell
2020-06-25 14:29 ` Alim Akhtar
2019-11-07 4:01 Stephen Rothwell
2019-11-07 15:51 ` Bart Van Assche
2019-11-08 23:02 ` James Smart
2019-06-20 6:10 Stephen Rothwell
2019-05-31 3:36 Stephen Rothwell
2019-06-03 20:29 ` Tyrel Datwyler
2019-06-03 23:37 ` Tyrel Datwyler
2019-04-05 3:25 Stephen Rothwell
2019-04-05 4:30 ` Bart Van Assche
2019-04-05 4:52 ` James Bottomley
2018-10-19 4:50 Stephen Rothwell
2018-10-19 4:54 ` James Bottomley
2018-10-19 4:58 ` Stephen Rothwell
[not found] <20180620132911.5f6ab464@canb.auug.org.au>
2018-07-10 7:31 ` Stephen Rothwell
2018-07-10 14:09 ` Jens Axboe
2018-07-10 14:14 ` James Bottomley
2018-07-10 14:22 ` Jens Axboe
2018-07-10 14:26 ` James Bottomley
2018-07-10 14:35 ` Jens Axboe
2018-07-10 15:08 ` Martin K. Petersen
2018-04-17 2:25 Stephen Rothwell
2018-04-18 21:52 ` Long Li
2018-04-18 23:30 ` Martin K. Petersen
2017-04-06 4:04 Stephen Rothwell
2017-04-06 8:18 ` Fam Zheng
2016-11-22 7:44 Stephen Rothwell
2016-11-22 22:24 ` Martin K. Petersen
2016-09-13 4:15 Stephen Rothwell
2016-09-13 14:09 ` Bryant G. Ly
2016-09-15 13:55 ` Martin K. Petersen
2014-11-18 8:21 Stephen Rothwell
2014-11-20 8:23 ` Christoph Hellwig
2013-09-02 8:28 Stephen Rothwell
2013-09-04 9:18 ` Sujit Reddy Thumma
2013-09-04 9:54 ` Sujit Reddy Thumma
2011-07-20 4:08 Stephen Rothwell
2010-08-04 3:13 Stephen Rothwell
2010-08-04 4:17 ` James Bottomley
2010-02-10 5:51 Stephen Rothwell
2010-02-10 22:13 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305773688.2856.449.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hch@lst.de \
--cc=joe.eykholt@gmail.com \
--cc=kiran.patil@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=yi.zou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).