From: Arnaud Lacombe <lacombar@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Arnaud Lacombe <lacombar@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Rodolfo Giometti <giometti@enneenne.com>,
linuxpps@ml.enneenne.com
Subject: [PATCH 07/11] drivers/pps: do not use EXTRA_CFLAGS
Date: Mon, 15 Aug 2011 01:07:10 -0400 [thread overview]
Message-ID: <1313384834-24433-8-git-send-email-lacombar@gmail.com> (raw)
In-Reply-To: <1313384834-24433-1-git-send-email-lacombar@gmail.com>
Usage of these flags has been deprecated for nearly 4 years by:
commit f77bf01425b11947eeb3b5b54685212c302741b8
Author: Sam Ravnborg <sam@neptun.(none)>
Date: Mon Oct 15 22:25:06 2007 +0200
kbuild: introduce ccflags-y, asflags-y and ldflags-y
Moreover, these flags (at least EXTRA_CFLAGS) have been documented for command
line use. By default, gmake(1) do not override command line setting, so this is
likely to result in build failure or unexpected behavior.
Replace their usage by Kbuild's `{as,cc,ld}flags-y'.
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Rodolfo Giometti <giometti@enneenne.com>
Cc: linuxpps@ml.enneenne.com
---
drivers/pps/generators/Makefile | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/pps/generators/Makefile b/drivers/pps/generators/Makefile
index 303304a..21e5e3b 100644
--- a/drivers/pps/generators/Makefile
+++ b/drivers/pps/generators/Makefile
@@ -4,6 +4,4 @@
obj-$(CONFIG_PPS_GENERATOR_PARPORT) += pps_gen_parport.o
-ifeq ($(CONFIG_PPS_DEBUG),y)
-EXTRA_CFLAGS += -DDEBUG
-endif
+ccflags-$(CONFIG_PPS_DEBUG) += -DDEBUG
--
1.7.6.153.g78432
next prev parent reply other threads:[~2011-08-15 5:08 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 5:07 [PATCH 00/11] Fix in-tree usage of EXTRA_{A,C,CPP,LD}FLAGS Arnaud Lacombe
2011-08-15 5:07 ` [PATCH 01/11] arch/m68k: do not use EXTRA_{A,C,LD}FLAGS Arnaud Lacombe
2011-08-15 5:11 ` Arnaud Lacombe
2011-08-15 7:26 ` Finn Thain
2011-08-15 14:45 ` Arnaud Lacombe
2011-08-15 5:07 ` [PATCH 02/11] arch/mips: do not use EXTRA_CFLAGS Arnaud Lacombe
2011-08-15 9:45 ` Sergei Shtylyov
2011-08-15 13:55 ` Ralf Baechle
2011-08-15 16:19 ` Arnaud Lacombe
2011-08-15 17:28 ` Jayachandran C.
2011-08-16 10:05 ` Ralf Baechle
2011-08-15 5:07 ` [PATCH 03/11] arch/unicore32: do not use EXTRA_AFLAGS or EXTRA_CFLAGS Arnaud Lacombe
2011-08-15 5:13 ` Arnaud Lacombe
2011-08-18 8:00 ` Guan Xuetao
2011-08-18 16:37 ` Arnaud Lacombe
2011-08-19 6:54 ` Guan Xuetao
2011-08-15 5:07 ` [PATCH 04/11] arch/x86: do not use EXTRA_CFLAGS Arnaud Lacombe
2011-08-15 5:14 ` Arnaud Lacombe
2011-08-15 5:07 ` [PATCH 05/11] drivers/media: " Arnaud Lacombe
2011-08-15 5:15 ` Arnaud Lacombe
2011-08-16 8:15 ` Laurent Pinchart
2011-08-15 5:07 ` [PATCH 06/11] drivers/net/bna: " Arnaud Lacombe
2011-08-15 5:16 ` Arnaud Lacombe
2011-08-15 5:07 ` Arnaud Lacombe [this message]
2011-08-15 5:16 ` [PATCH 07/11] drivers/pps: " Arnaud Lacombe
2011-08-15 5:07 ` [PATCH 08/11] drivers/scsi: " Arnaud Lacombe
2011-08-15 5:16 ` Arnaud Lacombe
2011-08-15 5:07 ` [PATCH 09/11] drivers/staging: " Arnaud Lacombe
2011-08-15 5:15 ` Arnaud Lacombe
2011-08-15 5:07 ` [PATCH 10/11] scripts/Makefile.build: do not reference EXTRA_CFLAGS as CFLAGS replacement Arnaud Lacombe
2011-08-22 15:50 ` Arnaud Lacombe
2011-08-31 14:43 ` Michal Marek
2011-08-15 5:07 ` [PATCH 11/11] script/checkpatch.pl: warn about deprecated use of EXTRA_{A,C,CPP,LD}FLAGS Arnaud Lacombe
2011-08-15 5:10 ` Arnaud Lacombe
2011-08-31 14:44 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313384834-24433-8-git-send-email-lacombar@gmail.com \
--to=lacombar@gmail.com \
--cc=giometti@enneenne.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxpps@ml.enneenne.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).