linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org, yrl.pp-manager.tt@hitachi.com,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@redhat.com>,
	"Frank Ch. Eigler" <fche@redhat.com>
Subject: Re: [PATCH 1/4] [BUGFIX] ftrace/kprobes: Fix not to delete probes if in use
Date: Sat, 08 Oct 2011 01:00:04 -0400	[thread overview]
Message-ID: <1318050006.4729.103.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20111004104438.14591.6553.stgit@fedora15>

On Tue, 2011-10-04 at 19:44 +0900, Masami Hiramatsu wrote:
> Fix kprobe-tracer not to delete a probe if the probe is in use.
> In that case, delete operation will return -EBUSY.
> 
> This bug can cause a kernel panic if enabled probes are deleted
> during perf record.
> 
> (Add some probes on functions)
> # perf record -e probe:\* -aR sh
> sh-4.2# perf probe --del probe:\*
> sh-4.2# exit
> (kernel panic)


Hi Masami,

I was able to reproduce the panic. I'm currently running patch 1 and 4
through my standard tests before pushing this out as urgent.

Does this exist in previous kernels? If so, I'll also add the stable tag
to it.

Could you resend the trivial patches when you make your necessary
corrections. They are not important as these are and I'll add them to a
separate queue.

Thanks!

-- Steve



  parent reply	other threads:[~2011-10-08  5:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-04 10:44 [PATCH 1/4] [BUGFIX] ftrace/kprobes: Fix not to delete probes if in use Masami Hiramatsu
2011-10-04 10:44 ` [PATCH 2/4] [TRIVIAL] ftrace/kprobes: Fix an warning typo Masami Hiramatsu
2011-10-04 15:58   ` Valdis.Kletnieks
2011-10-05  4:08     ` Masami Hiramatsu
2011-10-04 10:44 ` [PATCH 3/4] [TRIVIAL] perftools: Fix a typo of command name as trace-cmd Masami Hiramatsu
2011-10-04 10:45 ` [PATCH 4/4] [BUGFIX] perf probe: Fix to show correct error string Masami Hiramatsu
2011-10-08  5:00 ` Steven Rostedt [this message]
2011-10-10 14:14   ` [PATCH 1/4] [BUGFIX] ftrace/kprobes: Fix not to delete probes if in use Masami Hiramatsu
2011-10-10 19:11     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1318050006.4729.103.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=acme@redhat.com \
    --cc=fche@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=yrl.pp-manager.tt@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).