linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/5] perf stat: Add error message for EMFILE
Date: Sun, 29 Jan 2012 17:55:54 +0900	[thread overview]
Message-ID: <1327827356-8786-3-git-send-email-namhyung@gmail.com> (raw)
In-Reply-To: <1327827356-8786-1-git-send-email-namhyung@gmail.com>

When a user tries to open so many events, perf_event_oen syscall
may fail with EMFILE. Provide an advice for that case.

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
 tools/perf/builtin-stat.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 459b8620a5d9..f74f9a557c9a 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -477,6 +477,9 @@ static int run_perf_stat(int argc __used, const char **argv)
 				      "\t Consider tweaking"
 				      " /proc/sys/kernel/perf_event_paranoid or running as root.",
 				      system_wide ? "system-wide " : "");
+			} else if (errno == EMFILE) {
+				error("Too many events are opened.\n"
+				      "\t Try again after reducing the number of events.\n");
 			} else {
 				error("open_counter returned with %d (%s). "
 				      "/bin/dmesg may provide additional information.\n",
-- 
1.7.8.2


  parent reply	other threads:[~2012-01-29  8:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-29  8:55 [PATCH 1/5] perf top: Use active evsel for non-sample events on old kernel Namhyung Kim
2012-01-29  8:55 ` [PATCH 2/5] perf record: Add error message for EMFILE Namhyung Kim
2012-01-29 15:28   ` David Ahern
2012-01-30  1:09     ` Namhyung Kim
     [not found]       ` <CAKYOsXxxmG8xQfPcn9xW+Dzd_-Qo8jUv8071UHdC18RBatq=uw@mail.gmail.com>
2012-01-30 18:56         ` Arnaldo Carvalho de Melo
2012-01-29  8:55 ` Namhyung Kim [this message]
2012-01-29  8:55 ` [PATCH 4/5] perf tools: Remove unnecessary ctype.h inclusion Namhyung Kim
2012-01-31 13:22   ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-01-29  8:55 ` [PATCH 5/5] perf lock: Document lock info subcommand Namhyung Kim
2012-01-31 13:21   ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-01-30 18:55 ` [PATCH 1/5] perf top: Use active evsel for non-sample events on old kernel Arnaldo Carvalho de Melo
2012-01-31  0:31   ` Namhyung Kim
2012-01-31  0:34     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327827356-8786-3-git-send-email-namhyung@gmail.com \
    --to=namhyung@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).