From: Joe Perches <joe@perches.com>
To: "Víctor M. Jáquez L." <vjaquez@igalia.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
"Ramirez Luna, Omar" <omar.ramirez@ti.com>,
devel@driverdev.osuosl.org, Greg Kroah-Hartman <gregkh@suse.de>,
Ivan Gomez Castellanos <ivan.gomez@ti.com>,
Armando Uribe <x0095078@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c
Date: Mon, 30 Jan 2012 12:40:28 -0800 [thread overview]
Message-ID: <1327956028.25132.53.camel@joe2Laptop> (raw)
In-Reply-To: <20120130203312.GA3296@lit.local.igalia.com>
On Mon, 2012-01-30 at 21:33 +0100, Víctor M. Jáquez L. wrote:
> On Mon, Jan 30, 2012 at 11:53:00AM -0800, Joe Perches wrote:
> > I've done a patch here to tidspbridge that standardizes
> > printk output.
> >
> > Basically, the patch adds
> > #define pr_fmt(fmt) KBUILD_MODNAME "%s: ", __func__
> > to prefix "tidspbridge:%s:", removes the leading
> > "%s:...", __func__ from the uses, coalesces
> > formats and does argument alignment.
> >
> > It cleans up the DBC_ASSERT, DBC_REQUIRE and DBC_ENSURE
> > macros too.
>
> hehehe... I also have one for this... But I prefer yours: I'm a newbie :)
Well, given that you haven't done many of these, I prefer yours.
next prev parent reply other threads:[~2012-01-30 20:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 20:09 [PATCH 0/5] staging: tidspbridge: clean up drv_interface.c Víctor Manuel Jáquez Leal
2012-01-23 20:09 ` [PATCH 1/5] staging: tidspbridge: more readable code Víctor Manuel Jáquez Leal
2012-01-24 18:22 ` Felipe Contreras
2012-01-30 17:14 ` Ramirez Luna, Omar
2012-01-23 20:09 ` [PATCH 2/5] staging: tidspbridge: remove unused header Víctor Manuel Jáquez Leal
2012-01-24 17:45 ` Felipe Contreras
2012-01-30 17:15 ` Ramirez Luna, Omar
2012-01-23 20:09 ` [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c Víctor Manuel Jáquez Leal
2012-01-30 17:25 ` Ramirez Luna, Omar
2012-01-30 17:59 ` Víctor M. Jáquez L.
2012-01-30 19:29 ` Dan Carpenter
2012-01-30 19:53 ` Joe Perches
2012-01-30 20:33 ` Víctor M. Jáquez L.
2012-01-30 20:40 ` Joe Perches [this message]
2012-01-23 20:09 ` [PATCH 4/5] staging: tidspbridge: silence the compiler Víctor Manuel Jáquez Leal
2012-01-30 17:28 ` Ramirez Luna, Omar
2012-01-23 20:09 ` [PATCH 5/5] staging: tidspbridge: remove header inclusions Víctor Manuel Jáquez Leal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327956028.25132.53.camel@joe2Laptop \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=ivan.gomez@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=omar.ramirez@ti.com \
--cc=vjaquez@igalia.com \
--cc=x0095078@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).