From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753038Ab2AaKOM (ORCPT ); Tue, 31 Jan 2012 05:14:12 -0500 Received: from proofpoint-cluster.metrocast.net ([65.175.128.136]:40608 "EHLO proofpoint-cluster.metrocast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752132Ab2AaKOK (ORCPT ); Tue, 31 Jan 2012 05:14:10 -0500 Subject: Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter From: Andy Walls To: Danny Kukawka Cc: Rusty Russell , mchehab@redhat.com, Mauro Carvalho Chehab , ivtv-devel@ivtvdriver.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 31 Jan 2012 05:13:22 -0500 In-Reply-To: <1328004120.2821.8.camel@palomino.walls.org> References: <1327952458-7424-1-git-send-email-danny.kukawka@bisect.de> <1327952458-7424-6-git-send-email-danny.kukawka@bisect.de> <1328004120.2821.8.camel@palomino.walls.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.0.3 (3.0.3-1.fc15) Content-Transfer-Encoding: 8bit Message-ID: <1328004803.2821.15.camel@palomino.walls.org> Mime-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.6.7361,1.0.211,0.0.0000 definitions=2012-01-31_04:2012-01-31,2012-01-31,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 suspectscore=2 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=6.0.2-1012030000 definitions=main-1201310024 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2012-01-31 at 05:01 -0500, Andy Walls wrote: > On Mon, 2012-01-30 at 20:40 +0100, Danny Kukawka wrote: > > Fixed handling of 'radio' module parameter from module_param_array > > to module_param_named to fix these compiler warnings in cx18-driver.c: > > NACK. > > "radio" is an array of tristate values (-1, 0, 1) per installed card: > > static int radio[CX18_MAX_CARDS] = { -1, -1, > > and must remain an array or you will break the driver. > > Calling "radio_c" a module parameter named "radio" is wrong. > > The correct fix is to reverse Rusty Russel's patch to the driver in > commit 90ab5ee94171b3e28de6bb42ee30b527014e0be7 > to change the "bool" back to an "int" as it should be in ^^^^ Sorry, a typo here. Disregard the word "back". Regards, Andy > "module_param_array(radio, ...)" > > Regards, > Andy > > > In function ‘__check_radio’: > > 113:1: warning: return from incompatible pointer type [enabled by default] > > At top level: > > 113:1: warning: initialization from incompatible pointer type [enabled by default] > > 113:1: warning: (near initialization for ‘__param_arr_radio.num’) [enabled by default] > > > > Signed-off-by: Danny Kukawka > > --- > > drivers/media/video/cx18/cx18-driver.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/media/video/cx18/cx18-driver.c b/drivers/media/video/cx18/cx18-driver.c > > index 349bd9c..27b5330 100644 > > --- a/drivers/media/video/cx18/cx18-driver.c > > +++ b/drivers/media/video/cx18/cx18-driver.c > > @@ -110,7 +110,7 @@ static int retry_mmio = 1; > > int cx18_debug; > > > > module_param_array(tuner, int, &tuner_c, 0644); > > -module_param_array(radio, bool, &radio_c, 0644); > > +module_param_named(radio, radio_c, bool, 0644); > > module_param_array(cardtype, int, &cardtype_c, 0644); > > module_param_string(pal, pal, sizeof(pal), 0644); > > module_param_string(secam, secam, sizeof(secam), 0644); > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html