From: "Bae, Chang Seok" <chang.seok.bae@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@suse.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@kernel.org>,
"Lutomirski, Andy" <luto@kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Eric Biggers <ebiggers@kernel.org>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"Gairuboyina, Charishma1" <charishma1.gairuboyina@intel.com>,
"Dwarakanath, Kumar N" <kumar.n.dwarakanath@intel.com>,
"Krishnakumar,
Lalithambika" <lalithambika.krishnakumar@intel.com>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v4 08/13] x86/power/keylocker: Restore internal wrapping key from the ACPI S3/4 sleep states
Date: Wed, 22 Dec 2021 04:58:40 +0000 [thread overview]
Message-ID: <133514AD-0F75-4B54-8A74-E768B1E95CB1@intel.com> (raw)
In-Reply-To: <CAJZ5v0gbePA+rR9gMRnaJrUGS1MwF6UQzxrFZChy5i=11tgz-A@mail.gmail.com>
On Dec 17, 2021, at 07:42, Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> First, I would change the subject to "x86/PM/keylocker: Restore
> internal wrapping key on resume from ACPI S3/S4".
>
> On Tue, Dec 14, 2021 at 2:00 AM Chang S. Bae <chang.seok.bae@intel.com> wrote:
>>
>> When the system state switches to these sleep states, the internal
>> wrapping key gets reset in the CPU state.
>
> And here I would say
>
> "When the system enters the ACPI S3 or S4 sleep state, the internal
> wrapping key is discarded.”
>
<snip>
>> /**
>> * setup_keylocker - Enable the feature.
>> * @c: A pointer to struct cpuinfo_x86
>> @@ -49,6 +87,7 @@ void __ref setup_keylocker(struct cpuinfo_x86 *c)
>>
>> if (c == &boot_cpu_data) {
>> u32 eax, ebx, ecx, edx;
>> + bool backup_available;
>>
>> cpuid_count(KEYLOCKER_CPUID, 0, &eax, &ebx, &ecx, &edx);
>> /*
>> @@ -62,10 +101,49 @@ void __ref setup_keylocker(struct cpuinfo_x86 *c)
>> goto disable;
>> }
>>
>> + backup_available = (ebx & KEYLOCKER_CPUID_EBX_BACKUP) ? true : false;
>
> Why not
>
> backup_available = !!(ebx & KEYLOCKER_CPUID_EBX_BACKUP);
>
> Apart from this it looks OK, so with the above addressed, please feel
> free to add
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> to this patch.
Thanks Rafael! Will do.
Chang
next prev parent reply other threads:[~2021-12-22 4:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 0:51 [PATCH v4 00/13] x86: Support Key Locker Chang S. Bae
2021-12-14 0:52 ` [PATCH v4 01/13] Documentation/x86: Document " Chang S. Bae
2021-12-14 0:52 ` [PATCH v4 02/13] x86/cpufeature: Enumerate Key Locker feature Chang S. Bae
2021-12-14 0:52 ` [PATCH v4 03/13] x86/insn: Add Key Locker instructions to the opcode map Chang S. Bae
2021-12-14 0:52 ` [PATCH v4 04/13] x86/asm: Add a wrapper function for the LOADIWKEY instruction Chang S. Bae
2021-12-14 0:52 ` [PATCH v4 05/13] x86/msr-index: Add MSRs for Key Locker internal wrapping key Chang S. Bae
2021-12-14 0:52 ` [PATCH v4 06/13] x86/keylocker: Define Key Locker CPUID leaf Chang S. Bae
2021-12-14 0:52 ` [PATCH v4 07/13] x86/cpu/keylocker: Load an internal wrapping key at boot-time Chang S. Bae
2021-12-14 0:52 ` [PATCH v4 08/13] x86/power/keylocker: Restore internal wrapping key from the ACPI S3/4 sleep states Chang S. Bae
2021-12-17 15:42 ` Rafael J. Wysocki
2021-12-22 4:58 ` Bae, Chang Seok [this message]
2021-12-14 0:52 ` [PATCH v4 09/13] x86/cpu: Add a configuration and command line option for Key Locker Chang S. Bae
2021-12-14 0:52 ` [PATCH v4 10/13] crypto: x86/aes - Prepare for a new AES implementation Chang S. Bae
2021-12-14 0:52 ` [PATCH v4 11/13] crypto: x86/aes-kl - Support AES algorithm using Key Locker instructions Chang S. Bae
2021-12-24 17:42 ` Andy Lutomirski
2022-01-07 18:06 ` Bae, Chang Seok
2021-12-14 0:52 ` [PATCH v4 12/13] crypto: x86/aes-kl - Support CBC mode Chang S. Bae
2021-12-14 0:52 ` [PATCH v4 13/13] crypto: x86/aes-kl - Support XTS mode Chang S. Bae
2021-12-16 1:09 ` [PATCH v4 00/13] x86: Support Key Locker Eric Biggers
2022-01-05 21:55 ` Bae, Chang Seok
2022-01-06 5:07 ` Eric Biggers
2022-01-06 6:13 ` Bae, Chang Seok
2022-01-06 16:25 ` [dm-devel] " Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=133514AD-0F75-4B54-8A74-E768B1E95CB1@intel.com \
--to=chang.seok.bae@intel.com \
--cc=bp@suse.de \
--cc=charishma1.gairuboyina@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=kumar.n.dwarakanath@intel.com \
--cc=lalithambika.krishnakumar@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=rafael@kernel.org \
--cc=ravi.v.shankar@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).