From: David Ahern <dsahern@gmail.com>
To: acme@ghostprotocols.net, linux-kernel@vger.kernel.org
Cc: David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH 03/11] perf kvm: guest userspace samples should not be lumped with host uspace
Date: Fri, 20 Jul 2012 17:25:48 -0600 [thread overview]
Message-ID: <1342826756-64663-4-git-send-email-dsahern@gmail.com> (raw)
In-Reply-To: <1342826756-64663-1-git-send-email-dsahern@gmail.com>
e.g., perf kvm --host --guest report -i perf.data --stdio -D
shows:
1 599127912065356 0x143b8 [0x48]: PERF_RECORD_SAMPLE(IP, 5): 5671/5676: 0x7fdf95a061c0 period: 1 addr: 0
... chain: nr:2
..... 0: ffffffffffffff80
..... 1: fffffffffffffe00
... thread: qemu-kvm:5671
...... dso: <not found>
(IP, 5) means sample in guest userspace. Those samples should not be lumped
into the VMM's host thread. i.e, the report output:
56.86% qemu-kvm [unknown] [u] 0x00007fdf95a061c0
With this patch the output emphasizes it is a guest userspace hit:
56.86% [guest/5671] [unknown] [u] 0x00007fdf95a061c0
Looking at 3 VMs (2 64-bit, 1 32-bit) with each running a CPU bound
process (openssl speed), perf report currently shows:
93.84% 117726 qemu-kvm [unknown] [u] 0x00007fd7dcaea8e5
which is wrong. With this patch you get:
31.50% 39258 [guest/18772] [unknown] [u] 0x00007fd7dcaea8e5
31.50% 39236 [guest/11230] [unknown] [u] 0x0000000000a57340
30.84% 39232 [guest/18395] [unknown] [u] 0x00007f66f641e107
Signed-off-by: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
---
tools/perf/util/session.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 8e48559..90ee39d 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -918,7 +918,9 @@ static struct machine *
{
const u8 cpumode = event->header.misc & PERF_RECORD_MISC_CPUMODE_MASK;
- if (cpumode == PERF_RECORD_MISC_GUEST_KERNEL && perf_guest) {
+ if (perf_guest &&
+ ((cpumode == PERF_RECORD_MISC_GUEST_KERNEL) ||
+ (cpumode == PERF_RECORD_MISC_GUEST_USER))) {
u32 pid;
if (event->header.type == PERF_RECORD_MMAP)
--
1.7.10.1
next prev parent reply other threads:[~2012-07-20 23:26 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 23:25 [PATCH 00/11] perf tool: assorted cleanups and bug fixes David Ahern
2012-07-20 23:25 ` [PATCH 01/11] perf tool: add machine id to modules debug message David Ahern
2012-07-25 19:16 ` [tip:perf/core] perf symbols: Add " tip-bot for David Ahern
2012-07-20 23:25 ` [PATCH 02/11] perf kvm: set name for VM process in guest machine David Ahern
2012-07-25 12:12 ` Jiri Olsa
2012-07-25 19:17 ` [tip:perf/core] perf kvm: Set " tip-bot for David Ahern
2012-07-20 23:25 ` David Ahern [this message]
2012-07-25 12:13 ` [PATCH 03/11] perf kvm: guest userspace samples should not be lumped with host uspace Jiri Olsa
2012-07-25 19:18 ` [tip:perf/core] perf kvm: Guest " tip-bot for David Ahern
2012-07-20 23:25 ` [PATCH 04/11] perf kvm: fix bug resolving guest kernel syms - v2 David Ahern
2012-07-25 12:11 ` Jiri Olsa
2012-07-25 19:19 ` [tip:perf/core] perf kvm: Fix bug resolving guest kernel syms tip-bot for David Ahern
2012-07-20 23:25 ` [PATCH 05/11] perf kvm: use strtol for walking guestmount directory David Ahern
2012-07-23 18:09 ` Arnaldo Carvalho de Melo
2012-07-20 23:25 ` [PATCH 06/11] perf kvm: limit repetitive guestmount message to once per directory David Ahern
2012-07-23 18:11 ` Arnaldo Carvalho de Melo
2012-07-25 19:20 ` [tip:perf/core] perf kvm: Limit " tip-bot for David Ahern
2012-07-20 23:25 ` [PATCH 07/11] perf tools: dump exclude_{guest,host}, precise_ip header info too David Ahern
2012-07-25 19:20 ` [tip:perf/core] perf tools: Dump " tip-bot for David Ahern
2012-07-20 23:25 ` [PATCH 08/11] perf tool: precise mode requires exclude_guest David Ahern
2012-07-23 18:13 ` Arnaldo Carvalho de Melo
2012-07-24 14:20 ` David Ahern
2012-07-24 16:15 ` Robert Richter
2012-07-24 17:28 ` David Ahern
2012-07-24 18:03 ` Arnaldo Carvalho de Melo
2012-07-26 5:16 ` David Ahern
2012-07-26 8:08 ` Peter Zijlstra
2012-08-03 13:51 ` Robert Richter
2012-08-15 15:22 ` David Ahern
2012-09-05 15:43 ` David Ahern
2012-09-05 22:07 ` Peter Zijlstra
2012-09-06 17:44 ` Robert Richter
2012-09-06 18:19 ` David Ahern
2012-07-25 20:35 ` Peter Zijlstra
2012-07-26 5:50 ` Gleb Natapov
2012-07-26 8:07 ` Peter Zijlstra
2012-07-26 8:10 ` Gleb Natapov
2012-07-26 9:07 ` Robert Richter
2012-08-02 16:06 ` David Ahern
2012-09-06 19:02 ` Robert Richter
2012-09-06 19:17 ` David Ahern
2012-09-06 19:56 ` Robert Richter
2012-09-07 16:41 ` [PATCH] perf, ibs: Check syscall attribute flags Robert Richter
2012-09-07 16:50 ` David Ahern
2012-09-07 17:07 ` Robert Richter
2012-09-07 17:11 ` David Ahern
2012-09-07 17:20 ` David Ahern
2012-09-10 13:07 ` Robert Richter
2012-09-10 15:37 ` Arnaldo Carvalho de Melo
2012-09-07 17:25 ` Robert Richter
2012-09-07 16:56 ` Peter Zijlstra
2012-09-07 17:18 ` Robert Richter
2012-09-07 19:11 ` Peter Zijlstra
2012-09-10 9:30 ` [PATCH -v2] " Robert Richter
2012-09-14 6:17 ` [tip:perf/urgent] perf/x86/ibs: " tip-bot for Robert Richter
2012-07-20 23:25 ` [PATCH 09/11] perf top: error handling for counter creation should parallel perf-record David Ahern
2012-07-23 18:15 ` Arnaldo Carvalho de Melo
2012-07-24 14:01 ` David Ahern
2012-07-24 14:39 ` Arnaldo Carvalho de Melo
2012-07-20 23:25 ` [PATCH 10/11] perf tool: give user better message if precise is not supported David Ahern
2012-07-21 10:40 ` Namhyung Kim
2012-07-22 2:28 ` David Ahern
2012-07-20 23:25 ` [PATCH 11/11] perf kvm top: limit guest kernel info message to once David Ahern
2012-07-23 18:17 ` Arnaldo Carvalho de Melo
2012-07-24 14:02 ` David Ahern
2012-07-24 14:40 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342826756-64663-4-git-send-email-dsahern@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).