From: Michael Neuling <mikey@neuling.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kay Sievers <kay@vrfy.org>,
linuxppc-dev@ozlabs.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Wu Fengguang <fengguang.wu@intel.com>,
Joe Perches <joe@perches.com>,
"Paul E. McKenney" <paulmck@us.ibm.com>
Subject: Re: [PATCH v3] printk: Have printk() never buffer its data
Date: Tue, 10 Jul 2012 08:36:52 +1000 [thread overview]
Message-ID: <13501.1341873412@neuling.org> (raw)
In-Reply-To: <20120709170956.GB24728@kroah.com>
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Sun, Jul 08, 2012 at 07:55:55PM +0200, Kay Sievers wrote:
> > On Sat, 2012-07-07 at 07:04 +1000, Michael Neuling wrote:
> > > Whole kmsg below.
> >
> > I guess I have an idea now what's going on.
> >
> > > 4,47,0;WARNING: at /scratch/mikey/src/linux-ozlabs/arch/powerpc/sysdev/xics/xics-common.c:105
> > > 4,51,0;MSR: 9000000000021032 <SF,HV,ME,IR,DR,RI> CR: 24000042 XER: 22000000
> > > 4,54,0;TASK = c000000000b2dd80[0] 'swapper/0' THREAD: c000000000c24000 CPU: 0
> >
> > This is the warning on CPU#1, all fine, all in one line.
> >
> > > 6,74,0;console [tty0] enabled
> > > 6,75,0;console [hvc0] enabled
> >
> > Now the boot consoles are registered, which replays the whole buffer
> > that was collected up to this point. During the entire time the console
> > semaphore needs to be held, and this can be quite a while.
> >
> > > 4,87,24545;WARNING: at /scratch/mikey/src/linux-ozlabs/arch/powerpc/sysdev/xics/xics-common.c:105
> > > \4,91,24586;MSR: 9000000000021032
> > > 4,92,24590;<
> > > 4,93,24594;SF
> > > 4,94,24599;,HV
> > > 4,95,24604;,ME
> > > 4,96,24609;,IR
> > > 4,97,24614;,DR
> > > 4,98,24619;,RI
> > > 4,99,24623;>
> > > 4,104,24661; CPU: 1
> >
> > At the same time the CPU#2 prints the same warning with a continuation
> > line, but the buffer from CPU#1 can not be flushed to the console, nor
> > can the continuation line printk()s from CPU#2 be merged at this point.
> > The consoles are still locked and busy with replaying the old log
> > messages, so the new continuation data is just stored away in the record
> > buffer as it is coming in.
> > If the console would be registered a bit earlier, or the warning would
> > happen a bit later, we would probably not see any of this.
> >
> > I can fake something like this just by holding the console semaphore
> > over a longer time and printing continuation lines with different CPUs
> > in a row.
> >
> > The patch below seems to work for me. It is also here:
> > http://git.kernel.org/?p=linux/kernel/git/kay/patches.git;a=blob;f=kmsg-merge-cont.patch;hb=HEAD
> >
> > It only applies cleanly on top of this patch:
> > http://git.kernel.org/?p=linux/kernel/git/kay/patches.git;a=blob;f=kmsg-syslog-1-byte-read.patch;hb=HEAD
> >
> > Thanks,
> > Kay
> >
> >
> > Subject: kmsg: merge continuation records while printing
> >
> > In (the unlikely) case our continuation merge buffer is busy, we unfortunately
> > can not merge further continuation printk()s into a single record and have to
> > store them separately, which leads to split-up output of these lines when they
> > are printed.
> >
> > Add some flags about newlines and prefix existence to these records and try to
> > reconstruct the full line again, when the separated records are printed.
> > ---
> > kernel/printk.c | 119 ++++++++++++++++++++++++++++++++++++--------------------
> > 1 file changed, 77 insertions(+), 42 deletions(-)
>
> Michael, did this solve the issue for you?
It didn't but I've been working with Kay offline and what he pushed to
you and is now in your driver-core-linus branch is good. ie.
5becfb1 kmsg: merge continuation records while printing
... works for me.
Thanks,
Mikey
next prev parent reply other threads:[~2012-07-09 22:36 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 19:05 [PATCH v3] printk: Have printk() never buffer its data Steven Rostedt
2012-06-25 22:07 ` Andrew Morton
2012-06-25 23:55 ` Greg Kroah-Hartman
2012-06-26 0:01 ` Linus Torvalds
2012-06-26 0:23 ` Greg Kroah-Hartman
2012-06-26 0:40 ` Linus Torvalds
2012-06-26 0:56 ` Kay Sievers
2012-06-26 1:40 ` Linus Torvalds
2012-06-26 16:07 ` Kay Sievers
2012-06-26 16:30 ` Joe Perches
2012-06-26 16:58 ` Greg Kroah-Hartman
2012-06-26 17:00 ` Kay Sievers
2012-06-26 17:02 ` Greg Kroah-Hartman
2012-06-26 18:34 ` Greg Kroah-Hartman
2012-06-26 18:38 ` Greg Kroah-Hartman
2012-06-26 18:48 ` Greg Kroah-Hartman
2012-06-27 15:13 ` Steven Rostedt
2012-06-27 15:18 ` Steven Rostedt
2012-06-27 15:26 ` Kay Sievers
2012-06-28 7:38 ` Kay Sievers
2012-06-28 1:48 ` Greg Kroah-Hartman
2012-06-28 1:54 ` Steven Rostedt
2012-06-28 2:55 ` Steven Rostedt
2012-06-29 5:30 ` Greg Kroah-Hartman
2012-06-29 11:18 ` Steven Rostedt
2012-06-29 15:40 ` Greg Kroah-Hartman
2012-06-28 5:00 ` Joe Perches
2012-07-05 7:03 ` Michael Neuling
2012-07-05 8:39 ` Kay Sievers
2012-07-05 8:53 ` Kay Sievers
2012-07-05 10:20 ` Michael Neuling
2012-07-05 11:47 ` Kay Sievers
2012-07-05 12:50 ` Kay Sievers
2012-07-06 0:41 ` Michael Neuling
2012-07-06 0:56 ` Kay Sievers
2012-07-06 3:39 ` Michael Neuling
2012-07-06 3:47 ` Michael Neuling
2012-07-06 10:46 ` Kay Sievers
2012-07-06 15:12 ` Kay Sievers
2012-07-06 21:04 ` Michael Neuling
2012-07-08 17:55 ` Kay Sievers
2012-07-09 17:09 ` Greg Kroah-Hartman
2012-07-09 17:15 ` Joe Perches
2012-07-09 22:36 ` Michael Neuling [this message]
2012-07-09 21:42 ` Joe Perches
2012-07-09 22:10 ` Kay Sievers
2012-07-09 22:29 ` Joe Perches
2012-07-09 22:40 ` Kay Sievers
2012-07-09 23:32 ` Joe Perches
2012-07-09 23:41 ` Joe Perches
2012-06-26 0:18 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13501.1341873412@neuling.org \
--to=mikey@neuling.org \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=paulmck@us.ibm.com \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).